-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit command as user OS config option #1324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :) Just one thing, could we update config.md accordingly?
done in most recent commit. |
docs/Config.md
Outdated
@@ -213,6 +216,21 @@ os: | |||
openCommand: 'open {{filename}}' | |||
``` | |||
|
|||
### EditCommand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### EditCommand | |
### Configuring File Editing |
Slightly more domain-specific title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the change, along with some better English in that section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more thing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Made a couple minor changes to the wording, but otherwise all good
Adding
os.editCommand
as an optional user config, similar toos.openCommand
. If omitted in the config, falls back to the previous options. If included in the config, run{{os.openCommand}} {{filename}}
.Testing
Caveats
Docs
I haven't wrote any docs, but if the maintainers decide this is a desired feature, I can draft something up. To my knowledge, there currently is not any sections that describes how lazygit chooses the text editor for editCommand, so maybe I could add a section on that in
Config.md
.