Allow creation of annotated tags #1469
Conversation
|
@jesseduffield This PR still has some rough edges but let me know what you think of the general approach. Looks like most of tests related to tags broke since we would now have a menu before the creation so if we're going in this direction, I'll make sure to fix them :) |
fsmiamoto
force-pushed
the
feature/annotated_tags
branch
2 times, most recently
from
ce77fcb
to
208ed7b
Compare
|
Took the opportunity to give some updates to the docs on Integration Tests as the commands there were not working as expected. Not sure if what I did to fix the tests is the right thing but here's what I've done:
Although these tests are slow by their own nature, I've really liked the general approach! |
|
Also, not sure why the linting is failing on me 😅 |
fsmiamoto
force-pushed
the
feature/annotated_tags
branch
from
208ed7b
to
c40093d
Compare
|
Linting problems were caused by Go 1.17, fixed at #1479. |
pkg/gui/commits_panel.go
Outdated
| func (gui *Gui) afterTagCreate(tagName string) error { | ||
| return gui.refreshSidePanels(refreshOptions{mode: ASYNC, scope: []RefreshableView{COMMITS, TAGS}, then: func() { | ||
| // find the index of the tag and set that as the currently selected line | ||
| for i, tag := range gui.State.Tags { |
There was a problem hiding this comment.
now that we sort tags by date created, descending, we can just set the cursor to the top. We don't even need to do that in a then callback: we can do it immediately
| return gui.prompt(promptOpts{ | ||
| title: gui.Tr.TagNameTitle, | ||
| handleConfirm: func(tagName string) error { | ||
| return gui.prompt(promptOpts{ |
There was a problem hiding this comment.
I wonder here whether a single-line editor is going to suffice. I assume that people typically use annotated tags for the sake of writing release notes for a release, and that will require more than one line. At any rate I'm happy to release this and see if anybody wants multi-line just so that this code doesn't get stale
There was a problem hiding this comment.
Good point. I agree, we can definitely extend this later on.
|
The |
The instructions provided were not working as expected.
We can do this since they are already sorted by date created.
fsmiamoto
force-pushed
the
feature/annotated_tags
branch
from
6ff7ab3
to
a0614fb
Compare
|
Fixed the |
|
Just tested and it works fine. Nice work! |
What
Allow the creation of annotated tags.
This implementation only supports adding a message to the tag but it could be extended in the future.
Why
This was requested in #1381 as currently we only support creating the so called lightweight tags