Fix open link command in Windows #470 #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryooooooga
force-pushed
the
feature/fix-open-link
branch
from
ad332a5
to
e4770b5
Compare
mjarkk
suggested changes
Oct 12, 2021
mjarkk
approved these changes
Oct 12, 2021
| @@ -80,8 +80,8 @@ func TestOSCommandOpenFile(t *testing.T) { | |||
| { | |||
| "test", | |||
| func(name string, arg ...string) *exec.Cmd { | |||
| assert.Equal(t, "open", name) | |||
| assert.Equal(t, []string{"test"}, arg) | |||
| assert.Equal(t, "bash", name) | |||
There was a problem hiding this comment.
I can't see where the 'bash' comes from in this PR's code changes. Is that being added somewhere?
There was a problem hiding this comment.
That is OSCommand.Platform.Shell in ShellCommandFromString
| @@ -211,14 +211,14 @@ keybinding: | |||
|
|
|||
| ```yaml | |||
| os: | |||
| openCommand: 'cmd /c "start "" {{filename}}"' | |||
| openCommand: 'start "" {{filename}}' | |||
There was a problem hiding this comment.
Is this change backwards compatible with other users who've used the old format?
There was a problem hiding this comment.
Yes if the filename does not contain &. (However, it doesn't work with the current master either)
jesseduffield
requested changes
Oct 13, 2021
|
Thanks for making this :) merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #470 and #1497