Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instalation instructions for ubuntu #20

Merged
merged 1 commit into from
Aug 6, 2018
Merged

Add instalation instructions for ubuntu #20

merged 1 commit into from
Aug 6, 2018

Conversation

dawidd6
Copy link
Collaborator

@dawidd6 dawidd6 commented Aug 5, 2018

Hello, i took my time and packaged this software for Ubuntu 14.04 and up.

Also i see that Atom has removed a trailing space, how convenient.

@jesseduffield
Copy link
Owner

jesseduffield commented Aug 5, 2018

Nice :) Question: if I push new changes and want to update the ubuntu package, how does that work? I anticipate a fair bit of bug-fixing in the coming week and don't want things to be too tricky to republish

@dawidd6
Copy link
Collaborator Author

dawidd6 commented Aug 5, 2018

I've set up daily recipes, which means that whenever there is a new commit, the package building is triggered. Launchpad is pulling changes from repos once in a few hours i guess, so packages should be pretty much fresh if something doesn't break in the meantime, but i will be notified in such occurence.

@jesseduffield
Copy link
Owner

Cool :) Is there some way I can have visibility over that recipe setup? Just to ensure that it's pointing at the main repo etc

@andyli
Copy link

andyli commented Aug 6, 2018

I think you can set up a "team" in launchpad and have both of you in there. You can use "lazygit" as the team name and it would look more official.

@dawidd6
Copy link
Collaborator Author

dawidd6 commented Aug 6, 2018

Yes you are right, i will set up a team and then let you know about the details, so please wait with merge.

@dawidd6
Copy link
Collaborator Author

dawidd6 commented Aug 6, 2018

Rebased commit. Launchpad Team is now available here:
https://launchpad.net/~lazygit-team

It's a moderated team, so if anyone wants to join, a member of the team needs to approve it first. For now i'm the only member. PPA for daily builds is established, git repositories are imported and recipes ready to review.

Also debian packaging boilerplate is primarily stored here (PRs welcome):
https://github.com/dawidd6/debian-packaging

@jesseduffield
Copy link
Owner

fantastic work man that's awesome! I just requested to join the team.

@dawidd6
Copy link
Collaborator Author

dawidd6 commented Aug 6, 2018

Granted administrator access.

@jesseduffield
Copy link
Owner

@dawidd6 you said there are recipes ready to review, where would they be found?

@dawidd6
Copy link
Collaborator Author

dawidd6 commented Aug 6, 2018

@jesseduffield
Copy link
Owner

jesseduffield commented Aug 6, 2018

looks good to me! Are we good to merge this PR now?

@dawidd6
Copy link
Collaborator Author

dawidd6 commented Aug 6, 2018

Yep, i think we are.

@jesseduffield jesseduffield merged commit 3ee9687 into jesseduffield:master Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants