Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix initial scroll position of edit box #2123

Merged

Conversation

Ryooooooga
Copy link
Contributor

@Ryooooooga Ryooooooga commented Aug 18, 2022

  • PR Description

fix #2122

reword commit

before スクリーンショット 2022-08-18 23 18 50
after スクリーンショット 2022-08-18 23 20 23
  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@jesseduffield
Copy link
Owner

Nice work @Ryooooooga , do you know what might have caused this issue in the first place? I would expect a recent commit to be the culprit

@Ryooooooga
Copy link
Contributor Author

bisect shows 22d9824

@jesseduffield
Copy link
Owner

Ah cool. Silly me!

@mark2185 mark2185 mentioned this pull request Aug 27, 2022
@jesseduffield jesseduffield merged commit 448ff80 into jesseduffield:master Sep 1, 2022
@jesseduffield
Copy link
Owner

Sorry for the delay on this one. Good work!

@Ryooooooga Ryooooooga deleted the feature/edit-initial-scroll branch September 1, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Branch name cut off when pushing upstream
2 participants