Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter warnings #3351

Merged
merged 1 commit into from Mar 2, 2024
Merged

Fix linter warnings #3351

merged 1 commit into from Mar 2, 2024

Conversation

stefanhaller
Copy link
Collaborator

These started to pop up in my editor after I installed an update of gopls, I think.

@stefanhaller stefanhaller added the maintenance For refactorings, CI changes, tests, version bumping, etc label Mar 1, 2024
Copy link

codacy-production bot commented Mar 1, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -2.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (fe7d184) 48350 40511 83.79%
Head commit (e3809f3) 48348 (-2) 40507 (-4) 83.78% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3351) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

These started to pop up in my editor after I installed an update of gopls, I
think. It's unfortunate that we don't see them on CI.
@stefanhaller stefanhaller merged commit afb9980 into master Mar 2, 2024
13 of 14 checks passed
@stefanhaller stefanhaller deleted the fix-linter-warnings branch March 2, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance For refactorings, CI changes, tests, version bumping, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants