-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stagger popup panels #3694
Stagger popup panels #3694
Commits on Jun 27, 2024
-
Fix clicking outside of the commit description panel or suggestions p…
…anel We forgot to handle the "suggestions" and "commitDescription" view names. Instead of listing all the names of views that can appear in popups though, let's use the context kind for this, which feels more robust. This is a change in behavior: previously, clicking outside of the search or filter prompt would close the prompt, now it no longer does (because search has a persistent popup kind, but it wasn't listed in the list of view names before).
Configuration menu - View commit details
-
Copy full SHA for c3d1a79 - Browse repository at this point
Copy the full SHA c3d1a79View commit details -
Have only one of commit message and description on the context stack …
…at a time This is how we do it for confirmation with suggestions too, so be consistent. It will make things easier later in this branch if we only have one context per "panel" on the stack, even if the panel consists of two views. Concretely this means: - only push the message context onto the stack when opening the panel (this requires making the description view visible manually; we do the same for suggestions) - when switching between message and description, use ReplaceContext rather than PushContext
Configuration menu - View commit details
-
Copy full SHA for 22dc7fe - Browse repository at this point
Copy the full SHA 22dc7feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 34d7afc - Browse repository at this point
Copy the full SHA 34d7afcView commit details -
ResizeConfirmationPanel and resizeConfirmationPanel were identical, get rid of one of them.
Configuration menu - View commit details
-
Copy full SHA for ccc620e - Browse repository at this point
Copy the full SHA ccc620eView commit details -
Remove redundant resizeConfirmationPanel() call at panel creating time
We resize the panel in layout, so there's no need to do that after creation.
Configuration menu - View commit details
-
Copy full SHA for b795d91 - Browse repository at this point
Copy the full SHA b795d91View commit details
Commits on Jun 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 32cfe7a - Browse repository at this point
Copy the full SHA 32cfe7aView commit details -
Remove redundant calls to resize editable panels at creating time
The only purpose of this was to scroll the editable text correctly (see #2146); now that gocui takes care of that, we no longer need to do this.
Configuration menu - View commit details
-
Copy full SHA for bb01648 - Browse repository at this point
Copy the full SHA bb01648View commit details -
Remove return value from ResizeCurrentPopupPanel
It always returned nil, so there's no point in returning an error.
Configuration menu - View commit details
-
Copy full SHA for 1d502d3 - Browse repository at this point
Copy the full SHA 1d502d3View commit details -
Resize all open popup panels in layout, not just the topmost one
Probably not the most import feature in the world, but when resizing the terminal window while multiple popup panels were open at the same time, we would only resize the topmost one. The main reason for changing this is because it makes the next commit easier to implement.
Configuration menu - View commit details
-
Copy full SHA for 1ab1fb3 - Browse repository at this point
Copy the full SHA 1ab1fb3View commit details -
When opening a popup panel on top of another one, offset the new one a little bit down and to the right.
Configuration menu - View commit details
-
Copy full SHA for 4b6479b - Browse repository at this point
Copy the full SHA 4b6479bView commit details