Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #22

Closed
jessegrabowski opened this issue Feb 5, 2023 · 1 comment · Fixed by #30
Closed

Improve test coverage #22

jessegrabowski opened this issue Feb 5, 2023 · 1 comment · Fixed by #30
Labels
good first issue Good for newcomers help wanted Extra attention is needed important Fix this ASAP

Comments

@jessegrabowski
Copy link
Owner

Current testing suite is with in unittest, but it seems pytest is universally preferred among the scientific packages I follow. It will also give access to pytest-cov, which will complement #21

While I'm at it, I would like to add hypothesis as a dependency and re-write tests using that framework. Should ensure more robust coverage of core functionality (especially the parser).

@jessegrabowski jessegrabowski changed the title Refactor all tests from unittest to pytest and hypothesis Improve test coverage Apr 19, 2023
@jessegrabowski jessegrabowski added help wanted Extra attention is needed good first issue Good for newcomers important Fix this ASAP labels Apr 19, 2023
@jessegrabowski
Copy link
Owner Author

It turns out pytest and unittest play fine together, and I have pytest-cov set up. Now what is important is to get 100% coverage of the existing code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed important Fix this ASAP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant