Skip to content

Commit

Permalink
Merge pull request #115 from a-krebs/master
Browse files Browse the repository at this point in the history
Fix #114 HamlPyExtension filename extension check invalid
  • Loading branch information
jessemiller committed Jan 1, 2013
2 parents a37a974 + 15b7c90 commit e56c81b
Show file tree
Hide file tree
Showing 2 changed files with 48 additions and 2 deletions.
3 changes: 1 addition & 2 deletions hamlpy/ext.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ def get_file_extension(file_path):

def has_any_extension(file_path, extensions):
file_ext = get_file_extension(file_path)
return file_ext and extensions and [clean_extension(e) for e in extensions]

return file_ext and extensions and file_ext in [clean_extension(e) for e in extensions]

class HamlPyExtension(jinja2.ext.Extension):

Expand Down
47 changes: 47 additions & 0 deletions hamlpy/test/ext_test.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
import unittest
import os
from hamlpy.ext import has_any_extension

class ExtTest(unittest.TestCase):
"""
Tests for methods found in ../ext.py
"""

def test_has_any_extension(self):
extensions = [
'hamlpy',
'haml',
'.txt'
]
# no directory
self.assertTrue(has_any_extension('dir.hamlpy', extensions))
self.assertTrue(has_any_extension('dir.haml', extensions))
self.assertTrue(has_any_extension('dir.txt', extensions))
self.assertFalse(has_any_extension('dir.html', extensions))
# with dot in filename
self.assertTrue(has_any_extension('dir.dot.hamlpy', extensions))
self.assertTrue(has_any_extension('dir.dot.haml', extensions))
self.assertTrue(has_any_extension('dir.dot.txt', extensions))
self.assertFalse(has_any_extension('dir.dot.html', extensions))

# relative path
self.assertTrue(has_any_extension('../dir.hamlpy', extensions))
self.assertTrue(has_any_extension('../dir.haml', extensions))
self.assertTrue(has_any_extension('../dir.txt', extensions))
self.assertFalse(has_any_extension('../dir.html', extensions))
# with dot in filename
self.assertTrue(has_any_extension('../dir.dot.hamlpy', extensions))
self.assertTrue(has_any_extension('../dir.dot.haml', extensions))
self.assertTrue(has_any_extension('../dir.dot.txt', extensions))
self.assertFalse(has_any_extension('../dir.dot.html', extensions))

# absolute paths
self.assertTrue(has_any_extension('/home/user/dir.hamlpy', extensions))
self.assertTrue(has_any_extension('/home/user/dir.haml', extensions))
self.assertTrue(has_any_extension('/home/user/dir.txt', extensions))
self.assertFalse(has_any_extension('/home/user/dir.html', extensions))
# with dot in filename
self.assertTrue(has_any_extension('/home/user/dir.dot.hamlpy', extensions))
self.assertTrue(has_any_extension('/home/user/dir.dot.haml', extensions))
self.assertTrue(has_any_extension('/home/user/dir.dot.txt', extensions))
self.assertFalse(has_any_extension('/home/user/dir.dot.html', extensions))

0 comments on commit e56c81b

Please sign in to comment.