Skip to content

Commit

Permalink
fix: fix private vs. public properties so as to allow prod builds
Browse files Browse the repository at this point in the history
  • Loading branch information
jessepinho committed Apr 4, 2017
1 parent 2e8fc64 commit 02252d1
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion src/app/face/face.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export class FaceComponent implements OnChanges {
}
}

private handleSVGLoaded(svg: SVGSVGElement): void {
handleSVGLoaded(svg: SVGSVGElement): void {
this.selection = d3.select(svg);

this.face = this.selection.select('#face');
Expand Down
11 changes: 6 additions & 5 deletions src/app/timeline/timeline.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,12 @@ const MAX_DURATION_PER_TWEET = 5000;
styleUrls: ['./timeline.component.scss']
})
export class TimelineComponent implements OnInit {
private currentTweetIndex: number = -1;
private speed: number = 0.95;
currentTweetIndex: number = -1;
speed: number = 0.95;
tweets: Tweet[] = this.service.getTweets();
version: string = 'v' + packageJSON.version;

private timeout: number;
private tweets: Tweet[] = this.service.getTweets();
private version: string = 'v' + packageJSON.version;

constructor(
private service: TwitterService,
Expand All @@ -39,7 +40,7 @@ export class TimelineComponent implements OnInit {
this.timeout = setTimeout(this.nextTweet.bind(this), MAX_DURATION_PER_TWEET * (1 - this.speed));
}

private handleSpeedChange(speed: number): void {
handleSpeedChange(speed: number): void {
this.speed = speed;
clearTimeout(this.timeout);

Expand Down
5 changes: 2 additions & 3 deletions src/app/tweet/tweet.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,13 @@ import { TwitterService } from '../twitter.service';
styleUrls: ['./tweet.component.sass']
})
export class TweetComponent implements OnChanges {
@Input() private tweet: Tweet;
@Input() tweet: Tweet;
intensity: number;

constructor(
private service: TwitterService,
) {}

private intensity: number;

ngOnChanges(changes: SimpleChanges) {
if (changes.hasOwnProperty('tweet')) {
this.intensity = this.service.getTweetIntensity(this.tweet);
Expand Down

0 comments on commit 02252d1

Please sign in to comment.