New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/validate with soap #10
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...so we can use pkg_resources ok
...this is implicit in the schema
Pull Request Test Coverage Report for Build 55
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 55
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## develop #10 +/- ##
==========================================
Coverage ? 89.63%
==========================================
Files ? 4
Lines ? 164
Branches ? 0
==========================================
Hits ? 147
Misses ? 17
Partials ? 0
Continue to review full report at Codecov.
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
Implements validators against the SOAP schema which give reasonably sensible errors (KeyError when a key is wrong, ValueError when a constraint is violated) so we can bake this into other parts of the library.