Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/validate with soap #10

Merged
merged 19 commits into from May 16, 2018
Merged

Conversation

jesserobertson
Copy link
Owner

Fixes #4

Implements validators against the SOAP schema which give reasonably sensible errors (KeyError when a key is wrong, ValueError when a constraint is violated) so we can bake this into other parts of the library.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 55

  • 60 of 68 (88.24%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.0%) to 89.634%

Changes Missing Coverage Covered Lines Changed/Added Lines %
earthchem/validation.py 60 68 88.24%
Totals Coverage Status
Change from base Build 50: -1.0%
Covered Lines: 147
Relevant Lines: 164

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented May 16, 2018

Pull Request Test Coverage Report for Build 55

  • 60 of 68 (88.24%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.0%) to 89.634%

Changes Missing Coverage Covered Lines Changed/Added Lines %
earthchem/validation.py 60 68 88.24%
Totals Coverage Status
Change from base Build 50: -1.0%
Covered Lines: 147
Relevant Lines: 164

💛 - Coveralls

Robertson, Jess (Mineral Resources, Kensington) added 2 commits May 16, 2018 13:43
@codecov
Copy link

codecov bot commented May 16, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@0de6e87). Click here to learn what that means.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #10   +/-   ##
==========================================
  Coverage           ?   89.63%           
==========================================
  Files              ?        4           
  Lines              ?      164           
  Branches           ?        0           
==========================================
  Hits               ?      147           
  Misses             ?       17           
  Partials           ?        0
Impacted Files Coverage Δ
earthchem/validation.py 88.23% <88.23%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0de6e87...489eafa. Read the comment docs.

@jesserobertson jesserobertson merged commit 47aebbf into develop May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants