Add set_limit and helpers for enabling and disabling #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s can be used to enable/disable the charger.
|
Any plans to merge this? I'd love to have this functionality so I can create integrations to turn off charging if off grid for example |
jesserockz
reviewed
Mar 10, 2022
jesserockz
approved these changes
Mar 11, 2022
|
Thanks |
jesserockz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw the other pull request regarding the limits, however, I did not have the same results that were mentioned in the other pull request.
For me if I set the charger to 0 AMPS it stays at 0 AMPS. I think perhaps there are some nuances to set limit for cases between 0 and the max limit that I haven't fully explored. However, for the case I am most interested (Home Assistant) it looks like we can safely enable/disable at the charger using 0 and the Max charging rate.