Calling saveContext() from any thread

[markkrenek]

Is saveContext() intended to be called from any thread? The docs say "This function is performed in a block on the context's queue" implying that I can call it from any thread. However, the first line (context.hasChanges) is not thread safe. I discovered this because I have com.apple.CoreData.ConcurrencyDebug enabled.

I know that I can wrap saveContext() inside a performBlock call to avoid this.

[markkrenek]

Actually, if you enable com.apple.CoreData.ConcurrencyDebug in the example project, any save of a background context will trigger a concurrency crash, even though the initial call to saveContext() is wrapped in a performBlockAndWait.

saveContext() needs to delay checking hasChanges until inside performBlock.

[jessesquires]

Good catch @markkrenek ! 😄

Moving the hasChanges check sounds right. 👍

Want to submit a PR?

[jessesquires]

fixed by #65