Added JSQAudioMediaItem class #1495

eliburke · 2016-03-09T22:27:47Z

Implements #1049
Added a test case for the JSAAudioMediaItem class
Added a sample audio file to the demo project
Added a sample audio message to the demo project
Added a UIImage category to return the default pause image
Added the JSQAudioMediaItem header to the main header file
Added pause image (Creative Commons License) from NounProject:
https://thenounproject.com/term/pause/183517/

Added a test case for the JSAAudioMediaItem class Added a sample audio file to the demo project Added a sample audio message to the demo project Added a UIImage category to return the default pause image Added the JSQAudioMediaItem header to the main header file Added pause image (Creative Commons License) from NounProject: https://thenounproject.com/term/pause/183517/

jessesquires · 2016-03-10T02:36:05Z

@eliburke awesome! 🎉

Glanced through this. First impressions: 👍

I'll have a bit more feedback soon, within the next couple days. 😄

jessesquires · 2016-03-10T02:37:34Z

Also -- is this you? 😄

eliburke · 2016-03-10T14:13:29Z

Yep, that's me. As you can see from the timeline I don't spend much time on twitter. 😜

I haven't payed a lot of attention to how you make the sausage, but if you need me to fix bugs like the Travis CI warning, or tweak the API / property names, or submit to release_8.0, just let me know.

…1495 有人 pull requset ~ :) 完成录音基本功能,发送,明天添加个录音时的提示 HUD 就 ok

jessesquires · 2016-03-15T05:22:30Z

Hey @eliburke -- sorry for the delay here. I haven't forgotten. Will review soon.

…back and options to duck other audio. added a delegate to notify when the sound category is changed cleaned up some warnings and removed an unused property

eliburke · 2016-03-15T12:27:19Z

No worries.
I've updated my PR to fix the warnings and remove an unused property. I added a new property to allow users to control the playback audio category, and a delegate method to get notification if the audio category changes. My reasoning for this design is:

developers who don't care what sound category is set can ignore it. JSQAudioMediaItem will set the category to Playback and the options to Duck, Speaker, Bluetooth. Sound will play through the mute switch and to the selected outputs.
developers who need different sound options can set them
anyone who needs to restore the sound category to a particular setting can do so when they clean up the view controller. I didn't want to try and restore the category within JSQAudioMediaItem because it is possible to have multiple audio streams playing at once, and without some sort of singleton to manage the setting, things would likely go haywire.

If you think it's necessary I could add additional methods for starting and ending playback.

jessesquires · 2016-03-19T02:07:10Z

JSQMessagesViewController/Model/JSQAudioMediaItem.h

+
+@class JSQAudioMediaItem;
+@protocol JSQAudioMediaItemDelegate <NSObject>
+@optional


let's make these non-optional

jessesquires · 2016-03-19T02:28:09Z

Thanks @eliburke ! Finally left some comments. Mostly organization stuff.

One other concern:

Can we simplify by only storing the NSData or the NSURL and provide a computed property for the one we don't keep?

Actually, I don't think we can go NSData -> NSURL, but only NSURL -> NSData.

This will help simplify things a lot if we only have to worry about NSData internally.

JOMEN5 · 2016-03-22T10:11:21Z

looking forward to your guys update for JSQAudioMediaItem,I can't wait to use it.

eliburke · 2016-03-22T15:00:46Z

@JOMEN5 I'm on vacation with the family right now. Hard to find time for coding between kids and rum punch. I'll try to get an updated PR in the next couple of days.

eliburke · 2016-03-28T17:35:21Z

@jessesquires I've made the majority of your changes:

Collapsed the protocol to one non-optional method
Added a view config class
added a designated init and various convenience init methods
updated the timestamp format to match iMessages
updated various comments and pragmas
updated the fade in/out timer
added timer manipulation methods
removed the internal audio URL and isReadyToPlay properties, replaced with a convenience setter that calls NSData:dataWithContentsOfURL

The one change I did not make was moving the mediaView logic out into a separate class. To be frank, I don't see any value, just extra complexity. If you are thinking that this re-design would allow someone to provide their own view class that plugs into the audio media item, all of the avAudioPlayer controls and the timer would have would have to be shimmed into the new class with yet another protocol. Or, if you put the avAudioPlayer and timer into the new view class, the audio media item class becomes an empty container.

If someone REALLY wants to revamp the look of the audio player beyond the viewConfig settings, I think it would be far simpler to copy and modify the base implementation to suit.

JOMEN5 · 2016-04-04T14:10:10Z

@eliburke Thanks for your contribution! I'm here also remain @jessesquires update this PR when you have free time. Best wishes.

jessesquires · 2016-04-04T14:33:27Z

JSQMessagesViewController/Model/JSQAudioMediaItem.h

+
+@end
+
+@interface JSQAudioMediaViewConfiguration : NSObject


let's put this new class in its own file 😄

jessesquires · 2016-04-04T14:37:20Z

Thanks so much @eliburke !

Left a couple more really minor comments. Then I think this is good to go. 👍

codecov-io · 2016-04-04T14:49:27Z

Current coverage is `66.12%`

Merging #1495 into develop will increase coverage by +0.17% as of d65843f

@@            develop   #1495   diff @@
=======================================
  Files            59      63     +4
  Stmts          2109    2294   +185
  Branches          0       0       
  Methods                           
=======================================
+ Hit            1391    1517   +126
  Partial           0       0       
- Missed          718     777    +59

Review entire Coverage Diff as of d65843f

Powered by Codecov. Updated on successful CI builds.

JOMEN5 · 2016-04-04T15:02:19Z

Thanks @jessesquires and have you finish the task now? How can I get the latest version,just use pod update or pod 'JSQMessagesViewController', :git => 'https://github.com/jessesquires/JSQMessagesViewController.git', :branch => 'develop'?Looking forward to your reply.

Added boilerplate copyright code to all new files Added { } curlies where missing Updated properties to follow standard coding style Merge /w develop

…iewController into audioMedia

jessesquires · 2016-04-05T00:43:40Z

@eliburke let me know when those last couple fixes are pushed and i'll merge.

(or, if travis behaves, merge yourself 😄 )

Added a test case for the JSAAudioMediaItem class Added a sample audio file to the demo project Added a sample audio message to the demo project Added a UIImage category to return the default pause image Added the JSQAudioMediaItem header to the main header file Added pause image (Creative Commons License) from NounProject: https://thenounproject.com/term/pause/183517/ Added a delegate to notify when the sound category is changed Change the sound category to AVAudioSessionCategoryPlayback and options to duck other audio. Moved view properties to JSQAudioMediaViewAttributes Moved button image init to JSQAudioMediaViewAttributes Added convenience setter for url->nsdata

…iewController into audioMedia

jessesquires · 2016-04-06T14:57:40Z

🎉

Added JSQAudioMediaItem class

eliburke mentioned this pull request Mar 9, 2016

[Feature] Implement JSQAudioMediaItem #1049

Closed

jessesquires added the needs review label Mar 10, 2016

jessesquires self-assigned this Mar 10, 2016

jessesquires added this to the 7.2.1 milestone Mar 10, 2016

Big-Pi pushed a commit to iShawnWang/PiChat that referenced this pull request Mar 10, 2016

JSQ 竟然没有 AudioCell ,幸好 issues jessesquires/JSQMessagesViewController#…

7a32a1b

…1495 有人 pull requset ~ :) 完成录音基本功能,发送,明天添加个录音时的提示 HUD 就 ok

added code to change the sound category to AVAudioSessionCategoryPlay…

218eba9

…back and options to duck other audio. added a delegate to notify when the sound category is changed cleaned up some warnings and removed an unused property

jessesquires reviewed Mar 19, 2016
View reviewed changes

jessesquires added the in-progress label Mar 19, 2016

jessesquires reviewed Apr 4, 2016
View reviewed changes

jessesquires added ready to merge and removed in-progress needs review labels Apr 4, 2016

jessesquires modified the milestones: 8.0.0, 7.2.1 Apr 4, 2016

eburke added 3 commits April 4, 2016 14:38

Merge branch 'develop' into audioMedia

dddacde

Split view config out into a separate JSQAudioMediaViewAttributes class

c692917

Added boilerplate copyright code to all new files Added { } curlies where missing Updated properties to follow standard coding style Merge /w develop

Merge branch 'audioMedia' of https://github.com/eliburke/JSQMessagesV…

e820f77

…iewController into audioMedia

eliburke and others added 3 commits April 5, 2016 09:08

Merge branch 'develop' into audioMedia

975d4b7

Merge branch 'audioMedia' of https://github.com/eliburke/JSQMessagesV…

d65843f

…iewController into audioMedia

eliburke merged commit f656a7b into jessesquires:develop Apr 5, 2016

eliburke deleted the audioMedia branch April 5, 2016 15:39

jessesquires added enhancement and removed ready to merge labels Apr 6, 2016

jessesquires mentioned this pull request Apr 6, 2016

Update demo project for AudioMediaItem #1531

Closed

MacMeDan pushed a commit to MacMeDan/JSQMessagesViewController that referenced this pull request May 18, 2016

Merge pull request jessesquires#1495 from eliburke/audioMedia

9a960d3

Added JSQAudioMediaItem class

eliburke mentioned this pull request May 23, 2016

Write release notes for 7.3.0 #1592

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added JSQAudioMediaItem class #1495

Added JSQAudioMediaItem class #1495

eliburke commented Mar 9, 2016

jessesquires commented Mar 10, 2016

jessesquires commented Mar 10, 2016

eliburke commented Mar 10, 2016

jessesquires commented Mar 15, 2016

eliburke commented Mar 15, 2016

jessesquires Mar 19, 2016

jessesquires commented Mar 19, 2016

JOMEN5 commented Mar 22, 2016

eliburke commented Mar 22, 2016

eliburke commented Mar 28, 2016

JOMEN5 commented Apr 4, 2016

jessesquires Apr 4, 2016

jessesquires commented Apr 4, 2016

codecov-io commented Apr 4, 2016

JOMEN5 commented Apr 4, 2016

jessesquires commented Apr 5, 2016

jessesquires commented Apr 6, 2016


		@end

		@interface JSQAudioMediaViewConfiguration : NSObject

Added JSQAudioMediaItem class #1495

Added JSQAudioMediaItem class #1495

Conversation

eliburke commented Mar 9, 2016

jessesquires commented Mar 10, 2016

jessesquires commented Mar 10, 2016

eliburke commented Mar 10, 2016

jessesquires commented Mar 15, 2016

eliburke commented Mar 15, 2016

jessesquires Mar 19, 2016

Choose a reason for hiding this comment

jessesquires commented Mar 19, 2016

JOMEN5 commented Mar 22, 2016

eliburke commented Mar 22, 2016

eliburke commented Mar 28, 2016

JOMEN5 commented Apr 4, 2016

jessesquires Apr 4, 2016

Choose a reason for hiding this comment

jessesquires commented Apr 4, 2016

codecov-io commented Apr 4, 2016

Current coverage is 66.12%

JOMEN5 commented Apr 4, 2016

jessesquires commented Apr 5, 2016

jessesquires commented Apr 6, 2016

Current coverage is `66.12%`