Skip to content
This repository has been archived by the owner on Aug 14, 2019. It is now read-only.

[Accessibility] Make message view more voiceover friendly #886

Merged
merged 2 commits into from
Apr 20, 2016

Conversation

BillCarsonFr
Copy link
Contributor

  • Cell is now accessible and will speak sender name and message
  • Accessory button has now an accessibility label
  • Post announcement when message is received
  • Added accessibility label to toolbar’s text view
  • Notice : I cannot do all the translation, will need some help

- Cell is now accessible and will speak sender name and message
- Accessory button has now an accessibility label
- Post announcement when message is received
- Added accessibility label to toolbar’s text view
@jessesquires
Copy link
Owner

thanks @BillCarsonFr ! i'll have a look soon 👍

@BillCarsonFr
Copy link
Contributor Author

just noticed that i forgot to add the method to configure the cell accessibility in the .h, only updated the .m. I have been doing too much swift :)

@jessesquires jessesquires added this to the 7.2.1 milestone Dec 6, 2015
@anamika217
Copy link

Yesterday I got a message that Telegram has been updated to version 3.3.2
In the new version, accessibility feature for sender name is not active. Will it be provided in next update?
Thanks in advance!

@eliburke
Copy link
Collaborator

@BillCarsonFr can you update your PR?

@jessesquires This appears to work as advertised. I think it could use improvement, but it's a solid start.

Media cells with interactive behavior (Audio, Video) do not work with voiceover enabled. I think that in order to add that functionality we would need to add a property to the mediaItem that returns an array of views that JSQMessagesCollectionViewCell can expose via accessabilityElements. We could also add a media type / name property to further differentiate between different cell types.

I also noticed some differences between how it behaves and how iMessage behaves, but I'm just pointing them out.

  • Does not announce timestamps
  • Does not indicate if there are actions available (e.g. long press menu)
  • Announces the local sender's name (iMessage says "Your iMessage")

@codecov-io
Copy link

Current coverage is 66.40%

Merging #886 into develop will increase coverage by +0.10% as of 8ee4b27

@@            develop   #886   diff @@
======================================
  Files            63     63       
  Stmts          2321   2331    +10
  Branches          0      0       
  Methods                          
======================================
+ Hit            1539   1548     +9
  Partial           0      0       
- Missed          782    783     +1

Review entire Coverage Diff as of 8ee4b27

Powered by Codecov. Updated on successful CI builds.

@eliburke eliburke merged commit 38e80c2 into jessesquires:develop Apr 20, 2016
@jessesquires
Copy link
Owner

@eliburke 👍

@jessesquires
Copy link
Owner

Maybe we can consider more accessibility for v8.0

MacMeDan pushed a commit to MacMeDan/JSQMessagesViewController that referenced this pull request May 18, 2016
…es#886)

- Cell is now accessible and will speak sender name and message
- Accessory button has now an accessibility label
- Post announcement when message is received
- Added accessibility label to toolbar’s text view
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants