Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add icon for favicon.ico #14

Closed
wayou opened this issue Jul 28, 2014 · 5 comments
Closed

add icon for favicon.ico #14

wayou opened this issue Jul 28, 2014 · 5 comments

Comments

@wayou
Copy link

wayou commented Jul 28, 2014

really love this theme, especially the file icons in the treeview.

however, I noticed that there's no corresponding icon for the favicon.ico file.

I think it will be nicer if add one :)
favicon

@buschtoens
Copy link

Do you have an idea in mind? A five-pointed star maybe?

@wayou
Copy link
Author

wayou commented Oct 19, 2014

yeah, ⭐ seems a good choice

@jesseweed
Copy link
Owner

It'd be cool if we can figure out how to get Atom to display the actual favicon as the icon.

Star seems a good backup plan.

@wayou
Copy link
Author

wayou commented Dec 11, 2014

@jesseweed that would be nicer

@jesseweed
Copy link
Owner

I think favicon parsing is over my head (and probably outside the realm of possibility for a theme). So Icon for .ico files has been added in 0.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants