-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False negative comparison results #19
Comments
Nevermind, this is not a library issue. The "issue" is consistent on those pictures above only. |
This seems like something to do with imagemagick? Let me test these images manually with imagemagick. |
Don't worry about it, Jesse. It looks like the interaction of an one of my
layers with Mapbox's layers causes some random noise.
Can't really explain it yet, but it's definitely not an issue with the
library.
Thanks, tho
On Dec 4, 2018 20:17, "Jesse Zacharias" <notifications@github.com> wrote:
This seems like something to do with imagemagick? Let me test these images
manually with imagemagick.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ATe4_tbPza_c8nkIBbFS0JoonJ9QGDrdks5u10jJgaJpZM4ZBMNB>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
I'm getting some false-negative, image comparison results, even though the
diff
images don't show much difference or any difference at all.Potentially related to the how the report is generated after
compare images
is used or the number of pictures being compared.I suspect the alphabetical sorting of the images names might be playing some role here.
That is, if you have the list below:
and you sort it alphabetically, you get this:
...just a thought.
To Reproduce
I'll describe exactly my scenario, but there might be a general way to repro this.
baseline
images. Doesn't matter iffull screen
orelement
.test
mode.Expected behavior
Image dissimilarity exceeds threshold
error.visualReport.html
will in alphabetical order. That is the results are order like so:img10
andimg9
, always.diff
images forimg10
andimg9
would be mostly or completely white (tiny or no difference).Screenshots and files:
img10
:img10.png.txt
img10
:img10
img10
, the difference is just dust which wouldn't amount to the magnitude of the reported dissimilarity:Same case for
img9
. Dissimilarity: 0.15<3.74. Diff image:Desktop (please complete the following information):
Additional context
I will reduce the image count to 10 and later to 9, check the results and report back if I find any more clues.
Thanks!
The text was updated successfully, but these errors were encountered: