Performance enhancements #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
jessezach
commented
Nov 19, 2018
•
jessezach
commented
- Resize images before comparing. This improves Imagemagick's performance.
- Instead of writing tolerance into files. Write it into dictionary for faster get and put.
- Fail test case in console if rmse difference is more than threshold
- Stitch visualReport.html during test runtime.
jessezach
force-pushed
the
performance-fixes
branch
from
4cfafe9
to
90b1406
Compare
…images before compare to improve compare mcommand's performance stitch report while running tests, although old report needs to be deleted off manually before starting fresh test run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.