Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves README #20

Merged
merged 3 commits into from
Dec 18, 2018
Merged

Improves README #20

merged 3 commits into from
Dec 18, 2018

Conversation

DiegoSanchezE
Copy link
Contributor

Changes and Additions:
Adds documentation on:

  • the directory structure that the library creates.
  • how the library generates the baseline, actual & diff images.
  • what code needs to be deployed to successfully use the library.

Testing:

  • Does it look good?
  • Does it clarify the library's behavior?
  • Is it too much?

Expected result:

  • This helps the user understand how the library works/behaves.

Adds documentation on:
- the directory structure that the library creates.
- how the library generates the `baseline`, `actual` & `diff` images.
- what code needs to be deployed to successfully use the library.
@jessezach
Copy link
Owner

@DiegoSanchezE This looks good. The styling of keyword documentation can be improved maybe?
I'm working on deprecating reportgen in the next release and implement a flask based server for reporting.
User can then execute suite in test mode and moved all the images to baseline with a simple button click.
Or Acceptable actual images can be made baseline with a button click. We may have to modify the ReadMe accordingly.

@DiegoSanchezE
Copy link
Contributor Author

DiegoSanchezE commented Dec 6, 2018 via email

It also move the Keyword documentation to a better, more-coherent location in the document.
@jessezach jessezach changed the base branch from master to release/0.63 December 6, 2018 16:45
I had a friend try to install the RobotEyes requirements and noticed that the ImageMagick installation requirement was not clear enought.
He did not check the "Install Legacy Utilities (e.g. convert)" check mark and had a bad time... :p
This commit adds that note.
@jessezach
Copy link
Owner

I haven't been able to find enough time to finish the server based report feature. I don't want to hold this PR because of that. Merging this to master

@jessezach jessezach changed the base branch from release/0.63 to master December 18, 2018 17:15
@jessezach jessezach merged commit 15989e7 into jessezach:master Dec 18, 2018
@DiegoSanchezE DiegoSanchezE deleted the dev-workflow-documentation branch April 8, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants