Added support for element blur offset in case of frames #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bioneyez The solution looks good. Would you like to add support for iframes as well? |
|
Added the iframe support, please review it. I tested it briefly using w3school's iframe example page. |
|
Merging into release branch for further testing before release into master |
jessezach
added a commit
that referenced
this pull request
May 1, 2020
* release v/1.3.1 * Added support for element blur offset in case of frames (#51) * Added support for element blur offset in case of frames * Added support for iframe blur offset * Capture Full Screen now blurs the specified elements in all the frames and iframes Co-authored-by: lorand.fazakas <lorand.fazakas@asseco.hu> * bug fixes to blur elements in main window and exception fix when switching back to initial frame * if driver is mobile then do not resize image, also fix resize base image to current image to avoid exception while comparing Co-authored-by: bioneyez <bioneyez@gmail.com> Co-authored-by: lorand.fazakas <lorand.fazakas@asseco.hu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jz-jess
Important: It's just a proof of concept and it does not support iframe.
#50 (comment)