Fixing the issue of the fail attribute not existing in _end_test #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jessezach
added a commit
that referenced
this pull request
Jan 27, 2021
* Fixing the issue of the fail attribute not existing in _end_test (#80) Co-authored-by: Jose <josev814@gmail.com>
|
Released in v1.5.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When RobotEyes is included in the RobotFramework and it isn't used, the open_eyes method is never called.
If another task triggers a failure, Robot Eyes improperly handles the error. The self.fail attribute is set in open_eyes, but it needs to be set in either init or as a global variable for RobotEyes when it's invoked.
[ ERROR ] Calling method '_end_test' of listener 'RobotEyes' failed: AttributeError: 'RobotEyes' object has no attribute 'fail'I set it as a global variable for the class. So when open_eyes is triggered it will set the value for fail. I set the default value to False. This should remove the error that's encountered when other libraries have failed and RobotEyes has been included in the test suite, but open_eyes hasn't been invoked.