Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create official unshare variant for ARM #73

Closed
Govinda-Fichtner opened this issue Oct 28, 2015 · 6 comments
Closed

create official unshare variant for ARM #73

Govinda-Fichtner opened this issue Oct 28, 2015 · 6 comments

Comments

@Govinda-Fichtner
Copy link

While trying to get Docker integration tests running on ARM one major problem is that the current unshare image only works for x86.

Together with @StefanScherer I created a quick'n'dirty variant of the unshare image which can be found here: https://github.com/hypriot/armhf-unshare

As the unshare image is used for the integration tests makes me think that it also should be part of the official docker-library. Same as for the busybox image.

How could we best achieve this? How could I help?

@jessfraz
Copy link
Owner

I would say checking out the process in github.com/docker-library/official-images

@Govinda-Fichtner
Copy link
Author

@jfrazelle Just to make it clear: you agree that the images used in the integrations tests should be part of the docker-library/official-images?

@jessfraz
Copy link
Owner

eventually yes, but for now we can use personal repos

On Fri, Oct 30, 2015 at 3:18 AM, Govinda Fichtner notifications@github.com
wrote:

@jfrazelle https://github.com/jfrazelle Just to make it clear: you
agree that the images used in the integrations tests should be part of the
docker-library/official-images?


Reply to this email directly or view it on GitHub
#73 (comment)
.

Jessie Frazelle
4096R / D4C4 DD60 0D66 F65A 8EFC 511E 18F3 685C 0022 BFF3
pgp.mit.edu http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3

@tianon
Copy link

tianon commented Oct 30, 2015 via email

@jessfraz
Copy link
Owner

ya so it was supposed to be bad version of unshare iirc pinng @ewindisch

On Fri, Oct 30, 2015 at 10:28 AM, Tianon Gravi notifications@github.com
wrote:

I'm still hazy on what makes the unshare image different from the unshare
binary included in the Debian base image itself?


Reply to this email directly or view it on GitHub
#73 (comment)
.

Jessie Frazelle
4096R / D4C4 DD60 0D66 F65A 8EFC 511E 18F3 685C 0022 BFF3
pgp.mit.edu http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3

@ewindisch
Copy link

@jfrazelle @tianon The problem is/was that some versions of unshare don't work appropriately on all kernels. The jess/unshare image is of a version that is "mostly compatible" across different kernels. Also, it's really small.

If the version of unshare in the latest debian image works well across kernels, then by all means, use it instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants