Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of things to do #1

Closed
jessielw opened this issue Jun 27, 2020 · 3 comments
Closed

List of things to do #1

jessielw opened this issue Jun 27, 2020 · 3 comments
Assignees

Comments

@jessielw
Copy link
Owner

jessielw commented Jun 27, 2020

  • add more file input types
  • Add dts to core
  • Add dtsHD extract
  • Add all other supported audio codes
  • Increase probe etc
  • Build ffmpeg including all audio codes
  • Package program with ffprobe and ffmpeg instead of relying on PATH.
  • Double check window sizes.
  • Add center launch on all windows.
  • Add "original" audio channel as default. (Will require extra logic)
  • Do some tests in FFMPEG with a bat to limit command window output. (Possibly give the user the option to exit CLI or not after encode)
  • Start organizing the GUI. Make it look nicer.
  • Increase probsize to 50m for FFMPEG line
  • Increase analyzeduration to 100m for FFMPEG line
  • Add streams output screen of some sort
  • Add user default settings
  • Add default folder save path settings
  • Update 'About
  • Make all windows re-sizable
  • Make save file location default based off of what file input location is
  • Add mouse overs, especially for Opus. Or at least a help widow.
  • Add ac3 to input
  • Add option for user to see executed command line
  • Add option for user to see command line before execution.
  • Add option for job window to stay opened or closed after encode.
  • Eventually add drag and drop
  • Add support for piping FFMPEG to FDK-AAC.exe
  • Add ALAC encoder
  • Add FLAC encoder
  • Add QAAC encoder
  • Add as many input types as I can to DnD as well as Open File
  • Set an error window for incorrectly selected files via Open File (this is already done for DnD)
  • Change E-AC3 window to SpinBox widgets. To limit the crazy amount of bitrate selections.
  • Add ABR (Average Bitrate to all codecs that support it that doesn't have it)
  • Get automatic track type detection
  • Add batch convert
  • Add custom command line to each codec
  • Add title entry to each codec
  • Add a proper help function. That opens a wiki that needs to be created.
  • Add live codec output in each codecs window
  • Check rather mp3 original channel needs to be defined.
  • Add Audio Delay Settings (automatic detection AND manual input - relative delay)
  • add delay string to output (reg and relative to video delay) IF INPUT ALREADY HAS DELAY STRING IN FILENAME PULL IT FROM THAT
  • Revamp progress bar window
  • Fix progress bars for the DTS codec (seems to be bugged when inputting raw .dts)
  • Add support for .thd audio input
  • Add support for opusenc.exe (program supports FFMPEG libopus now, but some users would rather have the official tool)
  • Remove the need for mediainfo CLI (replace with mediainfolib)
  • Add new progress window to all codecs (ac3 is done as of now)
  • Add an optional, auto close window when done check button for new progress window
  • Remove included fdkaac.exe and qaac (non free libraries) with the program, this will require some programming to check for these to enable the above encoders, program will still fully support these codecs/encoders, but they will no longer automatically come with everything they need to use them - NEED TO ADD A WIKI PAGE FOR THESE AS WELL
  • Allow users to copy the contents of scrolled text widget once it's completed
  • Adjust libopus encoder mapping_family in the CLI, mono/stereo mapping_family 0 anything > stereo mapping_family 1
  • Consider adding support for the exhale aac audio encoder maybe
  • Add error checks upon file input, if file is missing audio tracks (use mediainfolib)
  • Change view command/show command box's to scrolledtextwidgets instead of a label window
  • Rework the entire eac3 window/command line, for visuals and for accuracy
  • Ask if user would like to overwrite file when starting job (if it exists of course)
  • Add button in progress window to open output directory (progress window)
  • If progess window doesn't ever contain string "size=", program did not complete job, handle this as an error (i.e. Job did not complete) Additionally, check for ffmpeg final string (check) before allowing GUI to display job completed as well as internally set job completion, in the event of an error the program will need to send a proper force close via PID to make sure all child processes stopped, automatically and sent again when the user closes the progess window to ensure everything is closed properly (progess window)
  • Remove "Original" channel mapping from DTS Encoder, set it to stereo/mono
  • 'total_duration' is detected via mediainfolib instead of the ffmpeg input (a lot less/cleaner code and completely accurate)
  • Add better 5.1 to stereo conversion options other then -ac 2 switch, see https://superuser.com/questions/852400/properly-downmix-5-1-to-stereo-using-ffmpeg and https://forum.doom9.org/showthread.php?p=1896134#post1896134 for references Actually, just use default audio switch -ac 2 but add a volume option to all codecs (in order to boost the volume)
  • QAAC/FDK-AAC add custom commands for both FFMPEG and external encoder
  • double check for switches -sn and -vn are sent to all codecs
  • fix flac wording on compression
  • Add language string to output
  • double check errors for THD input in progress window (said file error'd out but was complete in 1 test) Fixed, in order to fix it I had to re-work total duration and the all the code that had to do with that and progress bars
  • Adjust all "Audio Settings" windows "Track Selection" to show more. Language, delay, etc... + switch to mediainfolib
  • Maybe add official flac encoder
  • Opus mapping family still needs added to view command and actual job code
  • Put large codec windows inside of notebook tabs, to decrease the size of them and organize them
  • Stop two audio settings windows from being opened at once
  • Files with delay and language inside them, remove/replace them with new values in the filesave function
  • Add [Audio#(number)] output filename
  • Make program remember where it was closed last
  • themes, customize text boxes, etc
  • Add github tracker and discord for tools/help in help section of program
  • Make "About" window look better
  • Window Location Management window (add right click to reset per codec and add a reset all with prompt)
  • Work on View Streams (remember last position as well as visuals and using mediainfolib), work on fdk/qaac help windows, work on cmd line windows
  • Check root exit function top level children for view streams
  • make view streams close when apply is selected in audio settings windows
  • Add color code to streams/progress/command windows
  • Allow users to highlight what they want to copy in text windows
  • If there is an error, make program ignore "Automatically Close"
  • Create installer with inno installer
  • check how program runs from archive
  • Add re-sampler options reference (https://stackoverflow.com/questions/41420391/ffmpeg-flac-24-bit-96khz-to-16-bit-48khz)
  • Separate job window vs normal encoding window code, for both single-multiple encoding
  • Update main display command window instead of spawning a new one
  • Save cmd line window locations and view streams
  • Add pause/resume/etc to normal encoding window
  • Language selector for tracks maybe
  • Log each full job to a log file (read line.split(), this shoould happen in start job code)
  • Add (1) to file if already exists or prompt the user to change the name or overwrite
  • Add volume for ffmpeg in the QAAC window
  • Add logger to capture program errors (https://stackoverflow.com/questions/14906764/how-to-redirect-stdout-to-both-file-and-console-with-scripting)
  • Set program to delete any empty log files upon launch
  • multi thread logger
  • New batch encoder, to replace the old messy one
  • create a discord for all tools
  • mini track window, needs title corrected, label frame color changed
  • Add an extra "worker" to jobs manager
  • job manager, fix split where it displays what file it's doing with codec (parse earlier in the input section)
  • Add file batch window to save window location window (plus all the code needed to save it), this also needs to be completed to fix a bug, where the root window is not re-opening when selected 'X', so need to set the exit_function code
  • Add batch file default save directory
  • Set program to check if path to fdk (FDK is done) and qaac exists when choosing codecs with encoder menu, when file input functions are ran via main or batch
  • check job manager, delete selected files function, make it work like batch file input
  • window geometry module, line 281, needs corrected for batch positioning.get()
  • main module, line 5968, needs comment corrected from job to batch
@jessielw jessielw self-assigned this Jun 27, 2020
@jessielw jessielw changed the title List of things to add List of things to do Jul 1, 2020
jessielw pushed a commit that referenced this issue Jul 20, 2020
Removed invalid CBR option and channel layouts + added VBR option.
@masterkivat
Copy link

masterkivat commented Oct 25, 2021

Hi. Sorry if this is not the proper section to ask about an feature but is it possible to make your tool recognize when an audio have a delay and automatically adjust it on ffmpeg (or make it manual)? Sometimes I rip DVDs and there's some delay when we demux the content...
Hope you can do that in the future, I love your tool 👍

@jessielw
Copy link
Owner Author

jessielw commented Oct 25, 2021

Hi. Sorry if this is not the proper section to ask about an feature but is it possible to make your tool recognize when an audio have a delay and automatically adjust it on ffmpeg (or make it manual)? Sometimes I rip DVDs and there's some delay when we demux the content... Hope you can do that in the future, I love your tool 👍

Yes I believe I can do this easily enough. Give me a little bit as I need to stabilize the version of youtube-dl i'm working on and i'll add this into the program.

Upon further reading you would generally just want to delay the audio with the muxer you was muxing with. Rather that be mp4/mkv, you'd use that to delay the audio.

However, I can set it to where the audio is saved with the proper delay amount in the file name and also display it on the GUI. If you have any more suggestions about this, please feel free to let me know.

IE: Adding delay to an audio file, would have to either pad it to make it longer or trim it to make it shorter, not necessarily what you want. Since my program only messes with audio files atm, this would not be very useful, as adding the delay happens during the muxing process.

jessielw added a commit that referenced this issue Apr 8, 2022
* Program now uses what ever AUDIO track number it is from source file and adds it to a string in output file
Example: -map 0:a:0 is actually Track #1, 0:a:1 is Track #2 (Good way to be sure which file you encoded/etc)
* This works for both manual/auto encode jobs completely
@jessielw
Copy link
Owner Author

jessielw commented Apr 8, 2022

Hi. Sorry if this is not the proper section to ask about an feature but is it possible to make your tool recognize when an audio have a delay and automatically adjust it on ffmpeg (or make it manual)? Sometimes I rip DVDs and there's some delay when we demux the content... Hope you can do that in the future, I love your tool 👍

It the newest update my tool will detect this and add it to the output filename

@jessielw jessielw changed the title List of things to do List of things to do for v4.0 May 18, 2022
@jessielw jessielw changed the title List of things to do for v4.0 List of things to do May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants