Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of Things to Do #1

Open
5 of 7 tasks
jessielw opened this issue Jan 4, 2022 · 2 comments
Open
5 of 7 tasks

List of Things to Do #1

jessielw opened this issue Jan 4, 2022 · 2 comments
Assignees

Comments

@jessielw
Copy link
Owner

jessielw commented Jan 4, 2022

  • Ask if user would like to re-write the output file
  • Add themes
  • Make status bar functional
  • Fix steps in the process window (they are buggy/inaccurate right now)
  • Add chapter extractor for mp4
  • fix code with hover button and status bar (combine them)
  • Work on how the program handles audio delay
@jessielw jessielw self-assigned this Jan 4, 2022
jessielw added a commit that referenced this issue Jan 21, 2022
BUG FIXES:
* All of the title inputs pass the command ':name=' if empty for video, audio, and subtitle. This prevents the title from automatically taking the entire file input/command as the title
* Audio Delay gets set back to '0' if a file is opened that doesn't have any audio streams

NEW FEATURES + QUALITY OF LIFE:
* Thanks to jeanlf from gpac (mp4box) we are now able to define the ID's of the files we are inputting. So, the program now keeps the tracks in order EVEN when selecting a different audio track from an input (thank you very much jeanlf!!)
* That enables the user to place an input with multiple audio files and select which they want and it not mess up the order of the output streams.
* I've adjusted the audio choice pop up window to be larger, look cleaner, take focus over the main window, until a selection is made, and give focus back + close once a selection is made
* The audio choice pop up window will now only show up if there is more then 1 audio stream in a source file (if there is only 1 audio source, it works as before and sets the default input to track 1 and sets the output track to 1)
* Adjusted the color of the audio window and frame to make it stand out more from the main gui
* When the new audio window opens, the transparency of the main GUI decreases slightly to bring focus to the new window and is disabled
* Commented a lot of the new code, still need to work on commenting a lot of it
* Removed some un-needed code for row/column configs in the audio window track frame
* Renamed some code/variables to make them more easily identifiable
* The function "testing" has been changed into "close_audio_window" It restores transparency when the button "Choose Track" is selected in the gui, as well as re-enables the main gui, selects the track, and closes the new audio window
* Put in a few error/information boxes for when the user is doing something that could result in an error
 * All the inputs are set as "#1" instead of "#video" etc - this allows more control over what's being added to the file/the output ID
* Video, Audio, and Subtitle have now all had hard-coded output ID's to ":ID=1, :ID=2, and :ID=3" - This maintains the output order, thanks again gpac dev! :)
* The "View Command" button code has been updated to match the actual command being sent to mp4box.exe

**** Program is to a stable point, I'm going to spend a little bit testing/fine tuning anything that I find over the next day or two before releasing a stable 1.0 ****
@jessielw jessielw changed the title List of Things to Do for Stable 1.0 List of Things to Do Jan 25, 2022
@ayaxxchanz
Copy link

Hi.. is it possible for you to make importing .mkv file possible?

@jessielw
Copy link
Owner Author

jessielw commented Feb 19, 2022

Hi.. is it possible for you to make importing .mkv file possible?

Correction, this is an mp4 tool. By default it only supports mp4 and raw stream inputs.

I'm sure programmatically I could extract the mkv and import the raw file inside, if this is something you'd like done feel free to post it as a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants