fix: use import instead of require when loading runner
#148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
force-pushed
the
use-import-over-require
branch
from
fa24b19
to
773446e
Compare
mrazauskas
reviewed
Sep 14, 2022
| tests: Array<Test>, | ||
| watcher: TestWatcher, | ||
| onStart: OnTestStart, | ||
| onResult: OnTestSuccess, | ||
| onFailure: OnTestFailure, | ||
| options: TestRunnerOptions, | ||
| ): Promise<void> { | ||
| const runner = (await import(runPath)).default; |
There was a problem hiding this comment.
Hm.. I still see require in the lates version. Is this because of Babel:
const runner = (await Promise.resolve(`${runPath}`).then(s => _interopRequireWildcard(require(s)))).default;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shouldn't make much of a difference, but in theory it means
runPathcan point to an ESM module