Skip to content

Commit

Permalink
feat: add valid-title to recommended ruleset
Browse files Browse the repository at this point in the history
BREAKING CHANGE: recommend `valid-title` rule
  • Loading branch information
G-Rath authored and SimenB committed Sep 4, 2020
1 parent 7080952 commit 41f7873
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ installations requiring long-term consistency.
| [valid-describe](docs/rules/valid-describe.md) | Enforce valid `describe()` callback | ![recommended][] | |
| [valid-expect](docs/rules/valid-expect.md) | Enforce valid `expect()` usage | ![recommended][] | |
| [valid-expect-in-promise](docs/rules/valid-expect-in-promise.md) | Enforce having return statement when testing with promises | ![recommended][] | |
| [valid-title](docs/rules/valid-title.md) | Enforce valid titles | | ![fixable][] |
| [valid-title](docs/rules/valid-title.md) | Enforce valid titles | ![recommended][] | ![fixable][] |

<!-- end rules list -->

Expand Down
1 change: 1 addition & 0 deletions src/__tests__/__snapshots__/rules.test.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ Object {
"jest/valid-describe": "error",
"jest/valid-expect": "error",
"jest/valid-expect-in-promise": "error",
"jest/valid-title": "error",
},
},
"style": Object {
Expand Down
2 changes: 1 addition & 1 deletion src/rules/valid-title.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export default createRule<[Options], MessageIds>({
docs: {
category: 'Best Practices',
description: 'Enforce valid titles',
recommended: false,
recommended: 'error',
},
messages: {
titleMustBeString: 'Title must be a string',
Expand Down

0 comments on commit 41f7873

Please sign in to comment.