fix: add review suggestions

jest-community · Jul 1, 2020 · 96eaf9b · 96eaf9b
1 parent 825687e
commit 96eaf9b
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 17 deletions.
diff --git a/src/rules/__tests__/no-interpolation-inline-snapshot.test.ts b/src/rules/__tests__/no-interpolation-inline-snapshot.test.ts
@@ -18,7 +18,9 @@ ruleTester.run('no-interpolation-inline-snapshot', rule, {
     'expect(something).not;',
     'expect.toHaveAssertions();',
     'myObjectWants.toMatchInlineSnapshot({}, `${interpolated}`);',
+    'myObjectWants.toMatchInlineSnapshot({}, `${interpolated1} ${interpolated2}`);',
     'toMatchInlineSnapshot({}, `${interpolated}`);',
+    'toMatchInlineSnapshot({}, `${interpolated1} ${interpolated2}`);',
     'expect(something).toThrowErrorMatchingInlineSnapshot();',
     'expect(something).toThrowErrorMatchingInlineSnapshot(`No interpolation`);',
   ],

diff --git a/src/rules/no-interpolation-inline-snapshot.ts b/src/rules/no-interpolation-inline-snapshot.ts
@@ -27,25 +27,25 @@ export default createRule({
         const { matcher } = parseExpectCall(node);
 
         if (
-          (matcher?.name !== 'toMatchInlineSnapshot' &&
-            matcher?.name !== 'toThrowErrorMatchingInlineSnapshot') ||
-          matcher?.arguments === null
+          matcher &&
+          [
+            'toMatchInlineSnapshot',
+            'toThrowErrorMatchingInlineSnapshot',
+          ].includes(matcher.name)
         ) {
-          return;
+          // Check all since the optional 'propertyMatchers' argument might be present
+          matcher.arguments?.forEach(argument => {
+            if (
+              argument.type === AST_NODE_TYPES.TemplateLiteral &&
+              argument.expressions.length > 0
+            ) {
+              context.report({
+                messageId: 'noInterpolation',
+                node: argument,
+              });
+            }
+          });
         }
-
-        // Check all since the optional 'propertyMatchers' argument might be present
-        matcher.arguments.forEach(argument => {
-          if (
-            argument.type === AST_NODE_TYPES.TemplateLiteral &&
-            argument.expressions.length > 0
-          ) {
-            context.report({
-              messageId: 'noInterpolation',
-              node: argument,
-            });
-          }
-        });
       },
     };
   },