Skip to content

Commit

Permalink
feat(lowercase-name): rename to prefer-lowercase-title
Browse files Browse the repository at this point in the history
BREAKING CHANGE: renamed `lowercase-name` to `prefer-lowercase-title`
  • Loading branch information
G-Rath authored and SimenB committed Oct 10, 2021
1 parent 3434d9b commit b860084
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -154,7 +154,6 @@ installations requiring long-term consistency.
| ---------------------------------------------------------------------------- | ------------------------------------------------------------------- | ---------------- | ------------ |
| [consistent-test-it](docs/rules/consistent-test-it.md) | Have control over `test` and `it` usages | | ![fixable][] |
| [expect-expect](docs/rules/expect-expect.md) | Enforce assertion to be made in a test body | ![recommended][] | |
| [lowercase-name](docs/rules/lowercase-name.md) | Enforce lowercase test names | | ![fixable][] |
| [max-nested-describe](docs/rules/max-nested-describe.md) | Enforces a maximum depth to nested describe calls | | |
| [no-alias-methods](docs/rules/no-alias-methods.md) | Disallow alias methods | ![style][] | ![fixable][] |
| [no-commented-out-tests](docs/rules/no-commented-out-tests.md) | Disallow commented out tests | ![recommended][] | |
Expand All @@ -181,6 +180,7 @@ installations requiring long-term consistency.
| [prefer-expect-assertions](docs/rules/prefer-expect-assertions.md) | Suggest using `expect.assertions()` OR `expect.hasAssertions()` | | ![suggest][] |
| [prefer-expect-resolves](docs/rules/prefer-expect-resolves.md) | Prefer `await expect(...).resolves` over `expect(await ...)` syntax | | ![fixable][] |
| [prefer-hooks-on-top](docs/rules/prefer-hooks-on-top.md) | Suggest having hooks before any test cases | | |
| [prefer-lowercase-title](docs/rules/prefer-lowercase-title.md) | Enforce lowercase test names | | ![fixable][] |
| [prefer-spy-on](docs/rules/prefer-spy-on.md) | Suggest using `jest.spyOn()` | | ![fixable][] |
| [prefer-strict-equal](docs/rules/prefer-strict-equal.md) | Suggest using `toStrictEqual()` | | ![suggest][] |
| [prefer-to-be](docs/rules/prefer-to-be.md) | Suggest using `toBe()` for primitive literals | ![style][] | ![fixable][] |
Expand Down
@@ -1,4 +1,4 @@
# Enforce lowercase test names (`lowercase-name`)
# Enforce lowercase test names (`prefer-lowercase-title`)

## Rule details

Expand Down
2 changes: 1 addition & 1 deletion src/__tests__/__snapshots__/rules.test.ts.snap
Expand Up @@ -12,7 +12,6 @@ Object {
"rules": Object {
"jest/consistent-test-it": "error",
"jest/expect-expect": "error",
"jest/lowercase-name": "error",
"jest/max-nested-describe": "error",
"jest/no-alias-methods": "error",
"jest/no-commented-out-tests": "error",
Expand All @@ -39,6 +38,7 @@ Object {
"jest/prefer-expect-assertions": "error",
"jest/prefer-expect-resolves": "error",
"jest/prefer-hooks-on-top": "error",
"jest/prefer-lowercase-title": "error",
"jest/prefer-spy-on": "error",
"jest/prefer-strict-equal": "error",
"jest/prefer-to-be": "error",
Expand Down
@@ -1,7 +1,7 @@
import { TSESLint } from '@typescript-eslint/experimental-utils';
import dedent from 'dedent';
import resolveFrom from 'resolve-from';
import rule from '../lowercase-name';
import rule from '../prefer-lowercase-title';
import { DescribeAlias, TestCaseName } from '../utils';

const ruleTester = new TSESLint.RuleTester({
Expand All @@ -11,7 +11,7 @@ const ruleTester = new TSESLint.RuleTester({
},
});

ruleTester.run('lowercase-name', rule, {
ruleTester.run('prefer-lowercase-title', rule, {
valid: [
'it.each()',
'it.each()(1)',
Expand Down Expand Up @@ -247,7 +247,7 @@ ruleTester.run('lowercase-name', rule, {
],
});

ruleTester.run('lowercase-name with ignore=describe', rule, {
ruleTester.run('prefer-lowercase-title with ignore=describe', rule, {
valid: [
{
code: "describe('Foo', function () {})",
Expand All @@ -273,7 +273,7 @@ ruleTester.run('lowercase-name with ignore=describe', rule, {
invalid: [],
});

ruleTester.run('lowercase-name with ignore=test', rule, {
ruleTester.run('prefer-lowercase-title with ignore=test', rule, {
valid: [
{
code: "test('Foo', function () {})",
Expand All @@ -299,7 +299,7 @@ ruleTester.run('lowercase-name with ignore=test', rule, {
invalid: [],
});

ruleTester.run('lowercase-name with ignore=it', rule, {
ruleTester.run('prefer-lowercase-title with ignore=it', rule, {
valid: [
{
code: "it('Foo', function () {})",
Expand All @@ -325,7 +325,7 @@ ruleTester.run('lowercase-name with ignore=it', rule, {
invalid: [],
});

ruleTester.run('lowercase-name with allowedPrefixes', rule, {
ruleTester.run('prefer-lowercase-title with allowedPrefixes', rule, {
valid: [
{
code: "it('GET /live', function () {})",
Expand All @@ -343,7 +343,7 @@ ruleTester.run('lowercase-name with allowedPrefixes', rule, {
invalid: [],
});

ruleTester.run('lowercase-name with ignoreTopLevelDescribe', rule, {
ruleTester.run('prefer-lowercase-title with ignoreTopLevelDescribe', rule, {
valid: [
{
code: 'describe("MyClass", () => {});',
Expand Down
File renamed without changes.

0 comments on commit b860084

Please sign in to comment.