Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instruct in README about whether I still need to set env in my own config file if I extend the shareable config #658

Closed
ZYinMD opened this issue Sep 4, 2020 · 1 comment · Fixed by #659
Labels

Comments

@ZYinMD
Copy link

ZYinMD commented Sep 4, 2020

I extend "plugin:jest/recommended". I think I won't need to specify "env": { "jest/globals": true }, because the recommended config already has it? But I'm not sure. I don't know if a shareable config can contain fields other than rules. I think it may be able to contain all kinds of things? But that's just my guess.

So, please instruct in README something like "If you extend our config, you're no longer required to specify xxx and xxx. (I think env: { "jest/globals": true } and plugin: ["jest"] will be no longer required, but not sure). These settings are mentioned first in the readme, before mentioning the shareable config, so a developer who reads from top to bottom is very likely to follow the steps to add these fields first, then follow the next step to extend the recommended config, without knowing what they mean exactly .

Thanks!

@github-actions
Copy link

🎉 This issue has been resolved in version 24.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant