Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: properly configure smoke test #1003

Merged
merged 5 commits into from
Jan 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/smoke-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ jobs:
- uses: AriPerkkio/eslint-remote-tester-run-action@v3
with:
issue-title: 'Results of weekly scheduled smoke test'
eslint-remote-tester-config: smoke-test/eslint-remote-tester.config.js

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The action doesn't actually pick these .ts configurations by default since action parameter has default value for .js config: https://github.com/AriPerkkio/eslint-remote-tester-run-action/blob/e72eaaa36788a76ef9044271bebbbd83377e7d6d/action.yml#L14-L17

So this needs to be specified here:

    eslint-remote-tester-config: smoke-test/eslint-remote-tester.config.ts

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah I wondered if that might be the case 👍

eslint-remote-tester-config: smoke-test/eslint-remote-tester.config.ts
Copy link

@AriPerkkio AriPerkkio Jan 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@G-Rath this path is still incorrect 😄

-          eslint-remote-tester-config: smoke-test/eslint-remote-tester.config.ts
+          eslint-remote-tester-config: eslint-remote-tester.config.ts

#1002 (comment)

Edit: Right there's an open PR for this, great!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup

33 changes: 33 additions & 0 deletions eslint-remote-tester.config.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
'use strict';

import { Config } from 'eslint-remote-tester';
import {
getPathIgnorePattern,
getRepositories,
} from 'eslint-remote-tester-repositories';

const config: Config = {
repositories: getRepositories({ randomize: true }),
pathIgnorePattern: getPathIgnorePattern(),
extensions: ['js', 'jsx', 'ts', 'tsx'],
concurrentTasks: 3,
cache: false,
logLevel: 'info',
eslintrc: {
root: true,
env: {
es6: true,
},
parser: '@typescript-eslint/parser',
parserOptions: {
ecmaVersion: 2020,
sourceType: 'module',
ecmaFeatures: {
jsx: true,
},
},
extends: ['plugin:jest/all'],
},
};

export default config;
2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,8 @@
"eslint-plugin-import": "^2.25.1",
"eslint-plugin-node": "^11.0.0",
"eslint-plugin-prettier": "^3.4.1",
"eslint-remote-tester": "^2.1.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"eslint-remote-tester": "^2.1.0",
"eslint-remote-tester": "^2.1.1",

"eslint-remote-tester-repositories": "^0.0.3",
"husky": "^7.0.2",
"is-ci": "^3.0.0",
"jest": "^27.0.0",
Expand Down