fix: replace use of deprecated methods #1453
Conversation
github-actions
bot
added
rule: no-if
rule: no-test-return-statement
rule: prefer-mock-promise-shorthand
rule: no-disabled-tests
rule: no-jasmine-globals
rule: no-commented-out-tests
rule: prefer-comparison-matcher
rule: prefer-spy-on
rule: prefer-to-contain
rule: prefer-equality-matcher
rule: no-conditional-expect
rule: no-large-snapshots
bug
rule: no-done-callback
rule: expect-expect
rule: no-confusing-set-timeout
labels
G-Rath
force-pushed
the
update-context-usage
branch
from
3c12c98
to
f72605c
Compare
G-Rath
force-pushed
the
update-context-usage
branch
from
f72605c
to
6fb6b2d
Compare
| @@ -19,6 +19,32 @@ declare module '@typescript-eslint/utils/dist/ts-eslint/Rule' { | |||
| } | |||
| } | |||
|
|
|||
| declare module '@typescript-eslint/utils/dist/ts-eslint/SourceCode' { | |||
There was a problem hiding this comment.
can we avoid this by upgrading to v6?
There was a problem hiding this comment.
Yeah I implemented the types in typescript-eslint/typescript-eslint#7812
There was a problem hiding this comment.
sweet! we should probably do that in a major
| @@ -229,3 +229,63 @@ export const getFirstMatcherArg = ( | |||
|
|
|||
| return followTypeAssertionChain(firstArg); | |||
| }; | |||
|
|
|||
| /* istanbul ignore next */ | |||
There was a problem hiding this comment.
why do we need to ignore coverage?
There was a problem hiding this comment.
because only one branch in each function should ever get used depending on what ESLint version you're using, and coverage is only collected against a single ESLint version at a time (technically we could merge reports for CI but that'd still be a pain locally)
G-Rath
force-pushed
the
update-context-usage
branch
from
6fb6b2d
to
b8684f4
Compare
Yup, though I'll do that in a follow-up PR |
## [27.6.3](v27.6.2...v27.6.3) (2024-01-12) ### Bug Fixes * replace use of deprecated methods ([#1453](#1453)) ([9204a51](9204a51))
|
🎉 This PR is included in version 27.6.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Per https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/
Marking as a draft for now since there isn't an immediate need to land this and I want to dig a bit deeper into ESLint v9 etc in case there are other deprecations that might be upcoming.