Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(prefer-expect-assertions): use ESQuery selectors #170

Merged
merged 1 commit into from
Oct 2, 2018

Conversation

macklinu
Copy link
Collaborator

@macklinu macklinu commented Oct 2, 2018

Related to #158 and #169, this PR migrates to use selector syntax. If this helps with readability and maintenance, let's merge it; otherwise, happy to close any PR that makes things more complicated. 馃憤

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are awesome

@macklinu macklinu merged commit be29fba into master Oct 2, 2018
@macklinu macklinu deleted the refactor/prefer-expect-assertions branch October 2, 2018 22:32
@SimenB
Copy link
Member

SimenB commented Oct 14, 2018

馃帀 This PR is included in version 21.24.2 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants