Fix false positives with no-jasmine-globals #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not that exciting right now, but the upcoming commit needs the grouped if-block anyway.
Want to re-use it for no-jasmine-globals
|
Travis is upset about my commit message: Is that because of the capital "O" in spyOn? [Update: Oh, it's the capital F in Fix] |
Prior to this, similarly named local variables & parameters would trigger the no-jasmine-globals warning Fixes jest-community#156
jdelStrother
force-pushed
the
no-globals
branch
from
a3dd6c2
to
7f7b5ed
Compare
SimenB
reviewed
Nov 19, 2018
|
This is great, thanks! I left a nit, but would love for @macklinu to chime in as well before merging 🙂 |
SimenB
approved these changes
Nov 20, 2018
|
@macklinu could you take a look when you find the time? Feel free to merge (squash merge, make sure the commit message is semantic) if it's OK 🙂 |
|
🎉 This PR is included in version 22.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@SimenB sorry I didn’t get a chance to look before merging. Have been away from the computer for Thanksgiving holiday. This change looks great though! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #156. WDYT?