feat(rules): no-try-expect

[cartogram]

This rule prevents the use of expect inside catch blocks.

The following patterns are warnings:

it('foo', () => {
 try {
   foo(); // `foo` may be refactored to not throw exceptions, yet still appears to be tested here.
 } catch (err) {
   expect(err).toMatch(/foo error/);
 }
});
it('bar', async () => {
 try {
   await foo();
 } catch (err) {
   expect(err).toMatch(/foo error/);
 }
});

The following patterns are not warnings:

it('foo', () => {
 expect(() => foo()).toThrow(/foo error/);
});
it('bar', async () => {
 await expect(fooPromise).rejects.toThrow(/foo error/);
});

Related #295

[SimenB]

This is a great rule! 🙂

[jeysal]

Wondering if the rule should check for these and pass if the test uses it, for the cases where one might actually need complicated logic in a catch

[SimenB]

in that case I think an eslint-disable-next-line comments is better rather than try to make the rule too clever.

[jeysal]

Not if you eslint-disable without adding expect.assertions - the lint error could suggest adding expect.assertions to get rid of the warning and save someone from mindlessly disabling it

[SimenB]

🎉 This PR is included in version 22.13.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀