Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(index): move globals into json file #366

Merged
merged 1 commit into from Aug 6, 2019
Merged

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Aug 6, 2019

I was happily surprised to find out that git can cherry-pick across file types :D

@G-Rath G-Rath requested a review from SimenB August 6, 2019 08:08
@SimenB SimenB merged commit d285f8b into master Aug 6, 2019
@SimenB SimenB deleted the break-out-globals-json branch August 6, 2019 08:39
@SimenB
Copy link
Member

SimenB commented Aug 6, 2019

@G-Rath this fails locally:

$ yarn build && node -p 'require("./")'
internal/modules/cjs/loader.js:638
    throw err;
    ^

Error: Cannot find module './globals.json'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Module.require (internal/modules/cjs/loader.js:690:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/Users/simen/Development/eslint-plugin-jest/lib/index.js:7:39)
    at Module._compile (internal/modules/cjs/loader.js:776:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:787:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)

I fixed it with b61ec87 so this is just a heads up 🙂

@G-Rath
Copy link
Collaborator Author

G-Rath commented Aug 6, 2019

Let me guess - b/c it doesn't get copied over. duh that was silly of me to miss 😬

@SimenB
Copy link
Member

SimenB commented Aug 6, 2019

no worries, glad we caught it before release, tho

@G-Rath
Copy link
Collaborator Author

G-Rath commented Aug 6, 2019

I've been bitten before by that iirc - it's kind of weird b/c yeah TS gladly imports those files, but won't "build" them :/

@SimenB
Copy link
Member

SimenB commented Aug 7, 2019

🎉 This PR is included in version 22.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants