Next #579

G-Rath · 2020-05-12T08:37:37Z

This is a body for my PR

package.json

SimenB · 2020-08-16T10:14:43Z

@G-Rath do you wanna hold off for v4 of @typescript/eslint? Either way works for me. I doubt the changes in the utils will affect us, but who knows

G-Rath · 2020-08-16T10:21:50Z

@SimenB I was reading some stuff about it today in relation to prettier, and it sounded like it was very close to being released.

v4 has some shiny new packages like @typescript-eslint/scope that might be useful for us, and that I suspect won't play nice with the v3 components if we tried to use them, so unless theres a specific breaking change people are waiting on, I don't think theres much harm in waiting at least another week to see where @typescript-eslint is at.

(iirc we're pretty stable these days, so this major is just letting us internally bump a bunch of dependencies by dropping Node 8, but I could be forgetting something?)

SimenB · 2020-08-16T10:27:09Z

There are no changes in the util we use I believe, unless I misunderstand. Regardless, there is not rush in landing this. typescript@4 is supposed to come next week, that'll probably kick off some releases: microsoft/TypeScript#38510

SimenB · 2020-08-22T10:03:52Z

typescript-eslint/typescript-eslint#2260 (comment)

Note that our v4 release is entirely unrelated to TS v4 release

might not be worth waiting, but we can at least wait until monday and get the version of the utils that explicitly support v4 as a minimum

SimenB · 2020-08-22T11:46:08Z

Failing CI due to typescript-eslint/typescript-eslint#2388 - should be fixed Monday at which point I'll rebase again

SimenB · 2020-08-31T20:35:26Z

@G-Rath v4 made no difference to types or rules. Should we merge?

G-Rath · 2020-08-31T22:19:53Z

@SimenB I'm keen to merge, but would like to do so final checks - would you be ok waiting until tonight/tomorrow (iirc my tonight is your ~3am)?

I'm working in a makeshift space today as we've not got power today at home, so working o-natural with just the built-in laptop
peripherals 😂

SimenB · 2020-08-31T22:23:26Z

For sure, still no rush 🙂 Make sure to land #651 before (rebase) merging this one 👍

SimenB

Let's do it

BREAKING CHANGE: Jasmine globals are no marked as such

BREAKING CHANGE

These are not needed with `@typescript-eslint@3`

BREAKING CHANGE: `no-large-snapshots` runs on all files regardless of type Fixes #370

BREAKING CHANGE: recommend erroring for `no-jasmine-globals` rule

BREAKING CHANGE: recommend `valid-title` rule

BREAKING CHANGE: recommend `no-deprecated-functions` rule

BREAKING CHANGE: recommend `no-interpolation-in-snapshots` rule

BREAKING CHANGE: recommend `no-conditional-expect` rule

Closes #646

BREAKING CHANGE: rename `no-test-callback` to `no-done-callback`

BREAKING CHANGE: `no-done-callback` will now report hooks using callbacks as well, not just tests Fixes #649 Resolves #651

github-actions · 2020-09-04T11:29:17Z

🎉 This PR is included in version 24.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

SimenB · 2020-09-04T11:39:22Z

Woo! Thanks @G-Rath, this was a heavy one 🚀

G-Rath · 2020-09-05T00:40:49Z

@SimenB we didn't remove our deprecated rules 😬

This branch never got a PR opened.

SimenB · 2020-09-05T05:09:51Z

Bah. Next time 😃 Open a PR with it now so we don't lose track?

SimenB force-pushed the next branch from fdb0a0c to 61ee3c5 Compare May 12, 2020 08:47

G-Rath commented May 12, 2020

View reviewed changes

package.json Outdated Show resolved Hide resolved

G-Rath force-pushed the next branch 3 times, most recently from 9a8cbf0 to fdb81fd Compare May 17, 2020 09:17

G-Rath force-pushed the next branch 2 times, most recently from 4f6fe3c to 4ad14bc Compare May 26, 2020 21:01

G-Rath force-pushed the next branch 6 times, most recently from d28ffb3 to b22de65 Compare June 25, 2020 01:03

G-Rath force-pushed the next branch 3 times, most recently from 8d2bc7c to 6255746 Compare July 28, 2020 04:27

SimenB force-pushed the next branch 7 times, most recently from a542c31 to 2549e6a Compare July 30, 2020 12:31

G-Rath force-pushed the next branch from 2549e6a to d372330 Compare July 31, 2020 01:12

SimenB force-pushed the next branch from 3de333e to 15fdb0a Compare August 22, 2020 11:42

SimenB force-pushed the next branch from 4dab308 to 9c6b9d8 Compare August 31, 2020 20:35

SimenB approved these changes Sep 4, 2020

View reviewed changes

SimenB marked this pull request as ready for review September 4, 2020 10:57

SimenB and others added 12 commits September 4, 2020 13:18

fix: remove Jasmine globals (#596)

91062d4

BREAKING CHANGE: Jasmine globals are no marked as such

test: use undefined in case to increase coverage

36f0307

feat(no-large-snapshots): remove whitelistedSnapshots option

c87b44c

BREAKING CHANGE

chore: remove unneeded conditions (#594)

924b9af

These are not needed with `@typescript-eslint@3`

fix(no-large-snapshots): run on all files regardless of type (#637)

b584dee

BREAKING CHANGE: `no-large-snapshots` runs on all files regardless of type Fixes #370

feat: set no-jasmine-globals to error in recommended ruleset

b34ea13

BREAKING CHANGE: recommend erroring for `no-jasmine-globals` rule

feat: add valid-title to recommended ruleset

cb9e80e

BREAKING CHANGE: recommend `valid-title` rule

feat: add no-deprecated-functions to the recommended ruleset

313576e

BREAKING CHANGE: recommend `no-deprecated-functions` rule

feat: add no-interpolation-in-snapshots to the recommended ruleset

ad29726

BREAKING CHANGE: recommend `no-interpolation-in-snapshots` rule

feat: add no-conditional-expect to the recommended ruleset

de52dda

BREAKING CHANGE: recommend `no-conditional-expect` rule

chore: upgrade to typescript@4 (#650)

a56e797

Closes #646

refactor(no-test-callback): rename rule to no-done-callback (#653)

7bad84b

BREAKING CHANGE: rename `no-test-callback` to `no-done-callback`

SimenB force-pushed the next branch from 0474d3c to 6914310 Compare September 4, 2020 11:19

SimenB and others added 2 commits September 4, 2020 13:22

chore: migrate to yarn v2 (#655)

47e85bd

feat(no-done-callback): support hooks (#656)

ef8825f

BREAKING CHANGE: `no-done-callback` will now report hooks using callbacks as well, not just tests Fixes #649 Resolves #651

SimenB force-pushed the next branch from 6914310 to ef8825f Compare September 4, 2020 11:23

SimenB merged commit 3e6cb44 into master Sep 4, 2020

SimenB deleted the next branch September 4, 2020 11:26

github-actions bot added the released label Sep 4, 2020

SimenB mentioned this pull request Sep 8, 2020

"all" config includes deprecated rules #663

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Next #579

Next #579

G-Rath commented May 12, 2020 •

edited

SimenB commented Aug 16, 2020

G-Rath commented Aug 16, 2020

SimenB commented Aug 16, 2020

SimenB commented Aug 22, 2020

SimenB commented Aug 22, 2020

SimenB commented Aug 31, 2020

G-Rath commented Aug 31, 2020

SimenB commented Aug 31, 2020

SimenB left a comment

github-actions bot commented Sep 4, 2020

SimenB commented Sep 4, 2020

G-Rath commented Sep 5, 2020

SimenB commented Sep 5, 2020

Next #579

Next #579

Conversation

G-Rath commented May 12, 2020 • edited

SimenB commented Aug 16, 2020

G-Rath commented Aug 16, 2020

SimenB commented Aug 16, 2020

SimenB commented Aug 22, 2020

SimenB commented Aug 22, 2020

SimenB commented Aug 31, 2020

G-Rath commented Aug 31, 2020

SimenB commented Aug 31, 2020

SimenB left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 4, 2020

SimenB commented Sep 4, 2020

G-Rath commented Sep 5, 2020

SimenB commented Sep 5, 2020

G-Rath commented May 12, 2020 •

edited