Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(no-large-snapshots): deprecate `whitelistedSnapshots` for new name #632

Merged
merged 1 commit into from Jul 30, 2020

Conversation

@G-Rath
Copy link
Collaborator

G-Rath commented Jul 26, 2020

I'd be happy to deprecate passing in RegExp instances at the same time if we want to simplify things. I don't use the rule myself so not sure how heavily the RegExp support is used.

@G-Rath G-Rath requested a review from SimenB Jul 26, 2020
@G-Rath G-Rath force-pushed the rename-no-large-snapshots-property branch from 7b2ae7c to 7e1786a Jul 28, 2020
@G-Rath G-Rath force-pushed the rename-no-large-snapshots-property branch from 7e1786a to 02eee8a Jul 28, 2020
@SimenB
SimenB approved these changes Jul 30, 2020
Copy link
Member

SimenB left a comment

Should we just rename in the next major? I think we should push through and publish a new major pretty soon

@G-Rath
Copy link
Collaborator Author

G-Rath commented Jul 30, 2020

Yes (thats the plan) and yes - I think we're pretty good to go for the new major - the main thing left is to decide on what rules to make recommended.

@G-Rath G-Rath merged commit 706f5c2 into master Jul 30, 2020
24 checks passed
24 checks passed
commitlint
Details
Test on Node.js v8.x and eslint v5
Details
Test on Node.js v8.x and eslint v6
Details
Test on Node.js v10.x and eslint v5
Details
Test on Node.js v10.x and eslint v6
Details
Test on Node.js v10.x and eslint v7
Details
Test on Node.js v12.x and eslint v5
Details
Test on Node.js v12.x and eslint v6
Details
Test on Node.js v12.x and eslint v7
Details
Test on Node.js v13.x and eslint v5
Details
Test on Node.js v13.x and eslint v6 Test on Node.js v13.x and eslint v6
Details
Test on Node.js v13.x and eslint v7
Details
Test on Node.js v14.x and eslint v5
Details
Test on Node.js v14.x and eslint v6
Details
Test on Node.js v14.x and eslint v7
Details
docs
Details
Test on ubuntu-latest using Node.js LTS
Details
Test on windows-latest using Node.js LTS
Details
Test on macOS-latest using Node.js LTS
Details
danger
Details
Danger All green. Nice work.
Details
Semantic Pull Request ready to be squashed
Details
codecov/patch 100.00% of diff hit (target 100.00%)
Details
codecov/project 100.00% (target 100.00%)
Details
@G-Rath G-Rath deleted the rename-no-large-snapshots-property branch Jul 30, 2020
github-actions bot pushed a commit that referenced this pull request Jul 30, 2020
# [23.20.0](v23.19.0...v23.20.0) (2020-07-30)

### Features

* **no-large-snapshots:** deprecate `whitelistedSnapshots` for new name ([#632](#632)) ([706f5c2](706f5c2))
@github-actions
Copy link

github-actions bot commented Jul 30, 2020

🎉 This PR is included in version 23.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released label Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.