chore(no-standalone-expect): mark option as optional #636
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESLint won't stop you from passing in
undefined
, and considers it a value that exists when checking if it should use the default value rules can set.This actually should have been a TS error, but I believe the types for
@typescript-eslint
meant it didn't have the full picture? This in turn meant when upgrading innext
we changed a test to not passundefined
, thus losing a point of coverage.Programming is weird.