Add toIncludeSameMembers matcher #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure what the CI build failure is all about, it occurred a few times while I was developing this patch locally. I haven't touched |
|
I think that the reason CI fails is because the functions called are executed too quickly in between each other. |
|
Thanks @denizdogan all looks good. I'm still a little unsure of the name, I think I will rename it to be closer to the other |
mattphillips
changed the title
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Nov 25, 2020
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Dec 5, 2020
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Dec 8, 2020
gnprice
pushed a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Feature
Why
Because this matcher was needed for a project of mine :)
Notes
As discussed in #114 the name could probably be improved. I found it rather difficult to formulate a concise and correct description of the matcher in README.md, help would be appreciated.
I haven't used Jest's snapshot feature much, so it's possible that the snapshot file could be improved. I'm honestly not sure what it's supposed to contain exactly.
Housekeeping
yarn contributor)