Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove chalk to support browsers #140

Merged

Conversation

frederickfogerty
Copy link
Contributor

@frederickfogerty frederickfogerty commented Jun 25, 2018

From #139

What

Removes dependency on chalk. Right now the call to red has been removed. There is potential to run different code for this based on the platform, using a technique such as this, but I'm not sure how stable/supported this technique is.

Why

Chalk does not work in the browser. As Jest is moving to support browsers, it is important that jest-extended can work in browser as well.

Housekeeping

  • Unit tests
  • Documentation is up to date
  • No additional lint warnings
  • Add yourself to contributors list (yarn contributor)
  • Typescript definitions are added/updated where relevant

@codecov-io
Copy link

codecov-io commented Jun 25, 2018

Codecov Report

Merging #140 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #140   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          90     90           
  Lines         425    425           
  Branches       70     70           
=====================================
  Hits          425    425

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ffe04c...618e0d3. Read the comment docs.

@mattphillips mattphillips merged commit cf859d5 into jest-community:master Jul 30, 2018
@mattphillips
Copy link
Member

Thanks @frederickfogerty given how little chalk was used this is a sensible change 👍

@frederickfogerty frederickfogerty deleted the fred/remove-chalk branch July 30, 2018 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants