Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use import-all macro instead of explicit imports #142

Merged
merged 1 commit into from
Jul 30, 2018

Conversation

tejasbubane
Copy link
Contributor

What

Fixes #134

Why

Handle missing exports

Notes

Uses import-all.macro.

Housekeeping

  • Unit tests
  • Documentation is up to date
  • No additional lint warnings
  • Add yourself to contributors list (yarn contributor)
  • Typescript definitions are added/updated where relevant

@codecov-io
Copy link

Codecov Report

Merging #142 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #142   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          90     91    +1     
  Lines         425    427    +2     
  Branches       70     70           
=====================================
+ Hits          425    427    +2
Impacted Files Coverage Δ
src/matchers/index.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ffe04c...8a423a5. Read the comment docs.

@mattphillips
Copy link
Member

😍 love this thanks a lot @tejasbubane 👏

@mattphillips mattphillips merged commit a45463f into jest-community:master Jul 30, 2018
@tejasbubane tejasbubane deleted the import-all branch July 30, 2018 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants