Add Feature toBeHexadecimal Matcher #152
Conversation
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 101 103 +2
Lines 488 500 +12
Branches 83 85 +2
=====================================
+ Hits 488 500 +12
Continue to review full report at Codecov.
|
| expect(() => expect('#eeggee').toBeHexadecimal()).toThrowErrorMatchingSnapshot(); | ||
| }); | ||
|
|
||
| test('fails when given non-string', () => { |
There was a problem hiding this comment.
is it worth having a test for a string that isn't hexadecimal as well?
There was a problem hiding this comment.
Agreed. This boundary is already covered in the predicate test.
| export default expected => { | ||
| const re1 = RegExp(/^#\b[a-f0-9]{6}\b/gi); | ||
| const re2 = RegExp(/^#\b[a-f0-9]{3}\b/gi); | ||
| return re1.test(expected) || re2.test(expected); |
There was a problem hiding this comment.
is it worth naming these a bit more explicitly, e.g.
shortRegex
longRedex
I only ask because i read the regex 3 times before i spotted the 6 and 3 馃寽
There was a problem hiding this comment.
Agreed. This was lazy on my part.
|
LGTM thanks @mvpowers I am on my phone atm I鈥檒l release this when I鈥檓 at my computer next 馃槃 |
What
Feature
Why
This feature satisfies #149. This is a new matcher to verify a string is a valid HTML hex color.
Notes
Please let me know if I need to make any modifications 馃憤
Housekeeping
yarn contributor)