Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typings for toContainEntry, toContainEntries, toContainAllEntries and toContainAnyEntries #184

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

tleunen
Copy link
Contributor

@tleunen tleunen commented Nov 23, 2018

Having the entries to be [string, string] is a bit too limited.
Most the the time, the keys will be strings. Although they could be Symbols too now. But especially for the values where it could be anything...

Why

Typescript complaints when we try to use one of these functions with the entries of an object where the keys or values are not strings.

Housekeeping

@codecov-io
Copy link

Codecov Report

Merging #184 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #184   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         109    109           
  Lines         554    554           
  Branches       97     97           
=====================================
  Hits          554    554

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9cc718...4c7a58b. Read the comment docs.

@tleunen
Copy link
Contributor Author

tleunen commented Jan 29, 2019

@mattphillips - I know you're busy. But I'll appreciate if you can take a look when you have some time. No rush though.

@mattphillips mattphillips merged commit cf932f8 into jest-community:master Jan 29, 2019
@mattphillips
Copy link
Member

@tleunen dude my bad leaving this so long to merge!! This is a really nice change, that I can now appreciate as I'm using TS thanks a bunch. I've just published this under v0.11.1

@tleunen tleunen deleted the patch-1 branch January 29, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants