chore: migrate to named exports from rules #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #363 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 127 126 -1
Lines 806 744 -62
Branches 126 126
=========================================
- Hits 806 744 -62
Continue to review full report at Codecov.
|
SimenB
commented
Oct 9, 2021
| @@ -33,5 +33,13 @@ | |||
| "no-trailing-spaces": 1, | |||
| "object-curly-spacing": [1, "always"], | |||
| "quotes": ["warn", "single", { "avoidEscape": true }] | |||
| } | |||
| }, | |||
| "overrides": [ | |||
There was a problem hiding this comment.
mostly to give a squiggle for people rebasing old PRs (in addition to failing tests) - I expect all new to copy the approach of existent ones and not notice this rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using default export of an object to get a name for this is weird, and requires extra wrapping when reexporting them. Using named exports makes for a cleaner approach.
Also, using
export functioninstead ofexport constmakes #332 a bit cleaner (as it doesn't have to migrate from arrow functions)ignore whitespace: https://github.com/jest-community/jest-extended/pull/363/files?w=1