Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #33, toBeFunction #49

Merged
merged 3 commits into from
Oct 27, 2017
Merged

Issue #33, toBeFunction #49

merged 3 commits into from
Oct 27, 2017

Conversation

mprencipe
Copy link
Contributor

What

Why

Notes

Housekeeping

  • Unit tests
  • Documentation is up to date
  • No additional lint warnings
  • Add yourself to contributors list (yarn contributor)

});

describe('.not.toBeFunction', () => {
each([[false], [''], [0], [{}], [[]], [undefined], [null], [NaN]]).it('passes when not given true: %s', given => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test description just needs updating to from true to function

'passes when not given a function: %s'

expect(given).not.toBeFunction();
});

it('fails when given true', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment

@mattphillips
Copy link
Member

Just test descriptions need updating. Good job!

@mattphillips mattphillips merged commit 03c421b into jest-community:master Oct 27, 2017
@mattphillips
Copy link
Member

Good job @mprencipe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants