Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .toBePositive (#29) #56

Merged
merged 4 commits into from
Oct 26, 2017
Merged

Conversation

amishshah
Copy link
Contributor

What

Adding the currently unimplemented .toBePositive matcher

Why

Currently unimplemented

Notes

Housekeeping

  • Unit tests
  • Documentation is up to date
  • No additional lint warnings
  • Add yourself to contributors list (yarn contributor)

@amishshah amishshah changed the title Add .toBePositive Add .toBePositive (#29) Oct 23, 2017
@codecov-io
Copy link

codecov-io commented Oct 23, 2017

Codecov Report

Merging #56 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #56   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          46     48    +2     
  Lines         207    216    +9     
  Branches       28     30    +2     
=====================================
+ Hits          207    216    +9
Impacted Files Coverage Δ
src/matchers/toBePositive/index.js 100% <100%> (ø)
src/matchers/toBePositive/predicate.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 642924a...d6a0d47. Read the comment docs.

@mattphillips mattphillips merged commit 20f5023 into jest-community:master Oct 26, 2017
@mattphillips
Copy link
Member

Good job @hydrabolt

This was referenced Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants