Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #552 #585

Merged
Merged

Conversation

wh1t3cAt1k
Copy link
Contributor

This is a bugfix PR for typescript compilation error in the latest jest-extended for "toHaveBeenCalledBefore" and "toHaveBeenCalledAfter". (#552)

Why

In #552 the author cannot build his project without a workaround, I experience the same:

error TS2345: Argument of type 'MockedFunctionDeep<(localName: string) => void>' is not assignable to parameter of type 'MockInstance<unknown, unknown[]>'.
  The types returned by 'getMockImplementation()' are incompatible between these types.
    Type '((localName: string) => void) | undefined' is not assignable to type '((...args: unknown[]) => unknown) | undefined'.
      Type '(localName: string) => void' is not assignable to type '(...args: unknown[]) => unknown'.
        Types of parameters 'localName' and 'args' are incompatible.
          Type 'unknown' is not assignable to type 'string'.

Notes

Housekeeping

  • Unit tests
  • Documentation is up to date
  • No additional lint warnings
  • Typescript definitions are added/updated where relevant

@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2023

⚠️ No Changeset found

Latest commit: 51ef14a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #585 (adc6bad) into main (33aebee) will not change coverage.
The diff coverage is n/a.

❗ Current head adc6bad differs from pull request most recent head 51ef14a. Consider uploading reports for the commit 51ef14a to get more accurate results

@@            Coverage Diff            @@
##              main      #585   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           73        73           
  Lines          674       674           
  Branches       290       290           
=========================================
  Hits           674       674           

@keeganwitt keeganwitt merged commit 633e318 into jest-community:main Jun 5, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants