-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix playground file name #648
Conversation
|
friendly ping @mattphillips 😅 |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #648 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 73 73
Lines 674 674
Branches 290 290
=========================================
Hits 674 674 ☔ View full report in Codecov by Sentry. |
@SimenB It looks like this fixed this issue. How is this deployed to the live website? It doesn't look like it's through a changeset (unless I've misunderstood). |
@keeganwitt I think the website autodeploys. @mattphillips set it up, so I'm not sure 😅 https://github.com/jest-community/jest-extended/deployments/Production |
Annoyingly the site is hosted on Vercel and when I contacted them about making it an open source project/organisation (whatever they call it) so that anyone from the org can deploy, I never heard back 😢 I can re-trigger the deployment as me which should work but yeah need to contact Vercel again or switch to another provider that supports free open source orgs (suggestions welcome). When I'm next at the keyboard I'll deploy this. |
Netlify works for the Jest site fwiw |
Maybe I can swap to Netlify instead. In fact, this reminds me, I was thinking now that we have the Jestjs org on GitHub maybe we should move the community projects there? We could also move this site to a subdomain on jestjs.io domain? Something like jest-extended.jestjs.io |
It'd take a bit of work, but it's a static site, right? GitHub Pages would be another option. I deploy Maven site that way for another project. |
Fix playground file name
The testfile component automatically adds ".test.js" suffix
jest-extended/website/src/components/CustomSandpack.tsx
Line 56 in 61df485
What
playground.test.js.test.js -> playground.test.js
Why
Looks bad
Notes
Housekeeping
Unit testsDocumentation is up to dateNo additional lint warningsTypescript definitions are added/updated where relevant