Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-97 shorten console output #111

Merged

Conversation

cisum-la
Copy link
Contributor

@cisum-la cisum-la commented Nov 25, 2019

This PR resolves Issue-97

  • Added a new flag includeShortConsoleOutput: "false"
  • When this flag is set to true includeShortConsoleOutput: "true" only message value is displayed in test result output
  • Added 2 new tests
  • Confirmed all the tests pass locally.
  • Tested the PR locally by overwriting the jest-junit files in node_modules

@palmerj3
Copy link
Collaborator

Looks good to me! I'll merge now and publish a release tomorrow.

@palmerj3 palmerj3 merged commit 01a40a4 into jest-community:master Nov 25, 2019
@cisum-la
Copy link
Contributor Author

thanks @palmerj3 !

@palmerj3
Copy link
Collaborator

palmerj3 commented Dec 2, 2019

Sorry for the delay @cisum-la but v10.0.0 was just published containing this change. THANK YOU again for submitting this change! https://github.com/jest-community/jest-junit/releases/tag/v10.0.0

@robcresswell
Copy link

@palmerj3 Why was this published as a breaking change?

@palmerj3
Copy link
Collaborator

palmerj3 commented Dec 2, 2019

For new functionality I tend to publish major releases. But you're right this should not cause issues.

I tend to lean on the side of safety and publish major releases more often than required given that hundreds of thousands rely on this package in their CI environments.

@robcresswell
Copy link

@palmerj3 I understand the caution. The flip side is that now every engineer who goes to update their deps will have to track down this change, see that it in fact is not breaking, and then update... so there is a cost involved still.

Anyways, I appreciate you maintaining this lib, and thankyou for the quick response 😇

@cisum-la
Copy link
Contributor Author

cisum-la commented Dec 2, 2019

thanks @palmerj3 ! for releasing it!

dbjorge pushed a commit to microsoft/axe-pipelines-samples that referenced this pull request Dec 2, 2019
Bumps [jest-junit](https://github.com/jest-community/jest-junit) from 9.0.0 to 10.0.0.
<details>
<summary>Release notes</summary>

*Sourced from [jest-junit's releases](https://github.com/jest-community/jest-junit/releases).*

> ## v10.0.0
> Add option to shorten console output by [@&#8203;cisum-la](https://github.com/cisum-la) - [jest-community/jest-junit#111](https://github-redirect.dependabot.com/jest-community/jest-junit/pull/111)
</details>
<details>
<summary>Commits</summary>

- [`87e3413`](jest-community/jest-junit@87e3413) Merge pull request [#115](https://github-redirect.dependabot.com/jest-community/jest-junit/issues/115) from palmerj3/v10.0.0
- [`6509fb9`](jest-community/jest-junit@6509fb9) v10.0.0
- [`ca9240f`](jest-community/jest-junit@ca9240f) Merge pull request [#113](https://github-redirect.dependabot.com/jest-community/jest-junit/issues/113) from maxkomarychev/addFileAttribute-readme-fix
- [`badfa6f`](jest-community/jest-junit@badfa6f) Fix readme entry for `addFileAttribute`
- [`01a40a4`](jest-community/jest-junit@01a40a4) Merge pull request [#111](https://github-redirect.dependabot.com/jest-community/jest-junit/issues/111) from cisum-la/ISSUE-97-shorten-console-output
- [`50a49e4`](jest-community/jest-junit@50a49e4) Added tests for short console output
- [`771e44a`](jest-community/jest-junit@771e44a) Added options for short console output
- [`665893a`](jest-community/jest-junit@665893a) Added support for short console output
- [`764bc3d`](jest-community/jest-junit@764bc3d) Added note about short console output to README.md
- See full diff in [compare view](jest-community/jest-junit@v9.0.0...v10.0.0)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=jest-junit&package-manager=npm_and_yarn&previous-version=9.0.0&new-version=10.0.0)](https://dependabot.com/compatibility-score.html?dependency-name=jest-junit&package-manager=npm_and_yarn&previous-version=9.0.0&new-version=10.0.0)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the `.dependabot/config.yml` file in this repo:
- Update frequency
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)



</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shorten output of the newly implemented console logging junit xml
3 participants