Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix displayName usage in templates #179

Merged
merged 1 commit into from Sep 10, 2021

Conversation

D4N14L
Copy link
Contributor

@D4N14L D4N14L commented Sep 9, 2021

Usage of the displayName field was changed in Jest 24.x (see: displayName) to always return an object of the format:

{
    color: "...",
    name: "..."
}

The current implementation leads to the displayName template printing as [object Object] instead of the actual displayName value. This change fixes this by switching usage based on the property type.

@D4N14L
Copy link
Contributor Author

D4N14L commented Sep 9, 2021

cc @palmerj3

@palmerj3
Copy link
Collaborator

palmerj3 commented Sep 10, 2021

Thank you!

@palmerj3 palmerj3 merged commit 8e5f72b into jest-community:master Sep 10, 2021
@D4N14L
Copy link
Contributor Author

D4N14L commented Sep 21, 2021

@palmerj3 would it be possible to get a minor/patch version bump published? I was hoping to use this as soon as it's available :)

@palmerj3
Copy link
Collaborator

palmerj3 commented Sep 21, 2021

Yeah sorry I tried right after it was merged and github wasn't letting me create a release. I'll try again.

@palmerj3
Copy link
Collaborator

palmerj3 commented Sep 21, 2021

@D4N14L ok this is now published in 12.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants